Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 477088 - sys-block/partitionmanager-1.0.3_p20130623 fails to resize FAT32 partitions when built with --as-needed
Summary: sys-block/partitionmanager-1.0.3_p20130623 fails to resize FAT32 partitions w...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2013-07-16 17:15 UTC by Andrius Štikonas
Modified: 2015-02-04 12:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to fix issue (patch,651 bytes, patch)
2015-02-03 19:51 UTC, Karol Herbst
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius Štikonas 2013-07-16 17:15:25 UTC
Partitionmanager cmake script looks if ped_file_system_resize function is available in libparted and if it is found then cmake enables FAT32 support in partitionmanager.

When I run "emerge partitionmanager" I can see in the output

-- Looking for ped_file_system_resize
-- Looking for ped_file_system_resize - not found

However, if I download partitionmanager source and run "cmake .." then I get

-- Looking for ped_file_system_resize
-- Looking for ped_file_system_resize - found

Expected results:
emerged ebuild behaves in the same way as normal out of tree build. FAT32 resize is enabled in partitionmanager

Actual results:
FAT32 resize support is disabled.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2013-07-16 17:25:20 UTC
Which version of partitionmanager are you using?
Comment 2 Andrius Štikonas 2013-07-16 17:32:50 UTC
(In reply to Michael Palimaka (kensington) from comment #1)
> Which version of partitionmanager are you using?

Sorry, I forgot to mention but it is 1.0.3_p20130623. Actually, the older ebuild does not work at all due to missing udisks2 support.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2013-07-16 17:52:35 UTC
I can confirm, but I don't know what the cause is.

Running cmake manually but using the same arguments passed by portage does not reproduce the issue.
Comment 4 Johannes Huber (RETIRED) gentoo-dev 2013-11-23 19:01:38 UTC
Seems fixed in the meantime. Can you please confirm?

Current emerge output on ~amd64

> -- Looking for ped_file_system_resize
> -- Looking for ped_file_system_resize - found
Comment 5 Andrius Štikonas 2013-11-24 03:11:55 UTC
I don't have ~amd64, only stable so I can't test at the moment. Any idea what unstable package might fix it. I've checked and it is not cmake
Comment 6 Michael Palimaka (kensington) gentoo-dev 2014-04-22 16:49:37 UTC
Working here now on stable.
Comment 7 Andrius Štikonas 2014-04-23 09:36:28 UTC
(In reply to Michael Palimaka (kensington) from comment #6)
> Working here now on stable.

It is not working here on amd64 stable. Strange...
Comment 8 Andrius Štikonas 2015-02-03 17:13:53 UTC
It still doesn't work on both KDELibs4 and KF5 versions.

If I build using portage I still get

-- Looking for ped_file_system_clobber
-- Looking for ped_file_system_clobber - not found
-- Looking for ped_file_system_resize
-- Looking for ped_file_system_resize - not found

And manually using cmake

-- Looking for ped_file_system_clobber
-- Looking for ped_file_system_clobber - not found
-- Looking for ped_file_system_resize
-- Looking for ped_file_system_resize - found
Comment 9 Michael Palimaka (kensington) gentoo-dev 2015-02-03 18:52:13 UTC
I can reproduce in portage, and reproduce manually by sourcing the build's environment.
Comment 10 Andrius Štikonas 2015-02-03 19:03:50 UTC
(In reply to Michael Palimaka (kensington) from comment #9)
> I can reproduce in portage, and reproduce manually by sourcing the build's
> environment.

to be more precise:

declare -x LDFLAGS="-Wl,-O1 -Wl,--as-needed"
Comment 11 Karol Herbst 2015-02-03 19:51:05 UTC
Created attachment 395460 [details, diff]
patch to fix issue
Comment 12 Andrius Štikonas 2015-02-03 19:54:04 UTC
(In reply to Karol Herbst from comment #11)
> Created attachment 395460 [details, diff] [details, diff]
> patch to fix issue

Applied upstream
http://commits.kde.org/partitionmanager/dd59ed858163482841aab82f7c4ef96e3a385bb6
Comment 13 Michael Palimaka (kensington) gentoo-dev 2015-02-04 12:53:38 UTC
For future reference, apparently the failure was caused because the linking order for the feature check looked liks this: "... -lparted -lparted-fs-resize ...".

Since the feature check uses functions from parted-fs-resize only, --as-needed throws away -lparted. This causes undefined symbol errors since parted-fs-resize needs parted.
Comment 14 Michael Palimaka (kensington) gentoo-dev 2015-02-04 12:59:52 UTC
Andrius, I was going to do a snapshot to fix this issue in-tree, but it looks like partitionmanager has disappeared from releaseme?