Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 477024 - app-shells/gentoo-bashcomp: fix for bash-completion >=2.1-r1
Summary: app-shells/gentoo-bashcomp: fix for bash-completion >=2.1-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 477380
  Show dependency tree
 
Reported: 2013-07-16 08:26 UTC by Evgeny Bobkin
Modified: 2013-08-09 09:01 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
use directory where the modules are picked up from (foo.patch,1.44 KB, patch)
2013-07-16 14:40 UTC, Samuli Suominen (RETIRED)
Details | Diff
gentoo-bashcomp-20121024.ebuild.patch (gentoo-bashcomp-20121024.ebuild.patch,1.66 KB, patch)
2013-07-17 12:50 UTC, Alexander Tsoy
Details | Diff
gentoo-bashcomp patch (gentoo-bashcomp-20130717.patch,16.42 KB, patch)
2013-07-17 17:44 UTC, Alexander Tsoy
Details | Diff
gentoo-bashcomp-20121024.ebuild v2 (gentoo-bashcomp-20121024.ebuild.patch,1.82 KB, patch)
2013-07-17 17:46 UTC, Alexander Tsoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeny Bobkin 2013-07-16 08:26:33 UTC
# emerge -a1v bash-completion

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild     U ~] app-shells/bash-completion-2.1-r1::gentoo [2.1::x-overlay] 0 kB
[uninstall     ] app-shells/gentoo-bashcomp-20101217-r1 
[blocks b      ] <app-shells/gentoo-bashcomp-20130101 ("<app-shells/gentoo-bashcomp-20130101" is blocking app-shells/bash-completion-2.1-r1)

Total: 1 package (1 upgrade, 1 uninstall), Size of downloads: 0 kB
Conflict: 1 block

Would you like to merge these packages? [Yes/No] no

Quitting.

Reproducible: Always
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2013-07-16 12:13:07 UTC

*** This bug has been marked as a duplicate of bug 472938 ***
Comment 2 Scott Thomson 2013-07-16 12:32:40 UTC
Hum, I don't think this is a duplicate of #472938, if anything it has been introduced by it.

As far as I can tell the blockage is because the new app-shells/bash-completion-2.1-r1 ebuild needs a higher version of app-shells/gentoo-bashcomp (20130101) which is not in the tree.

Typo in ebuild or missed file from commit perhaps?
Comment 3 Evgeny Bobkin 2013-07-16 12:46:13 UTC
(In reply to Jeroen Roovers from comment #1)
> 
> *** This bug has been marked as a duplicate of bug 472938 ***

Sorry, but it's not a duplicate of bug 472938
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-07-16 14:40:32 UTC
Created attachment 353460 [details, diff]
use directory where the modules are picked up from

propably path issue... not sure of futher incompabilities. try it, modify it, submit it ;)

emerge --nodeps -av gentoo-bashcomp
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2013-07-16 14:47:29 UTC
also removed the blocker for now. downside is you get to keep the broken / misplaced files now, until this is resolved
Comment 6 Alexander Tsoy 2013-07-16 14:49:45 UTC
(In reply to Samuli Suominen from comment #4)

"repoman" and "layman" should work that way. But "gentoo" completion should be either installed in compatdir:

$ pkg-config --variable=compatdir bash-completion
/etc/bash_completion.d

or splitted in separate files to support dynamic loading (completion name should match command name).
Comment 7 Alexander Tsoy 2013-07-17 12:50:45 UTC
Created attachment 353494 [details, diff]
gentoo-bashcomp-20121024.ebuild.patch

This one works for me.
Comment 8 Alexander Tsoy 2013-07-17 17:44:49 UTC
Created attachment 353524 [details, diff]
gentoo-bashcomp patch

- Do not use deprecated have() function.
- Move gentoo_style_init completion in separate file. It doesn't support dynamic loading so it should be installed in compatdir.
- Cleanup spaces at the end of lines.
Comment 9 Alexander Tsoy 2013-07-17 17:46:56 UTC
Created attachment 353526 [details, diff]
gentoo-bashcomp-20121024.ebuild v2

Resulting ebuild needs patched gentoo-bashcomp sources.
Comment 10 shinydoofy 2013-07-27 16:10:35 UTC
(In reply to Alexander Tsoy from comment #7)
> Created attachment 353494 [details, diff] [details, diff]
> gentoo-bashcomp-20121024.ebuild.patch
> 
> This one works for me.
This one works for me as well, thanks! The second one, however, doesn't due to the patch failing (for layman iirc). Symlinking, tbh, doesn't feel very good, but at least it's working again.

Could a dev please take a look at this? I'd love to see an updated ebuild in portage.
Comment 11 Alexander Tsoy 2013-07-27 16:21:28 UTC
(In reply to shinydoofy from comment #10)
> (In reply to Alexander Tsoy from comment #7)
> > Created attachment 353494 [details, diff] [details, diff] [details, diff]
> > gentoo-bashcomp-20121024.ebuild.patch
> > 
> > This one works for me.
> The second one, however, doesn't due to the patch failing (for layman iirc).

My patch should apply on git HEAD.

http://git.overlays.gentoo.org/gitweb/?p=proj/gentoo-bashcomp.git

> Symlinking, tbh, doesn't feel very good, but at least it's working again.

This approach is recommended by upstream. You can find it in README.
Comment 12 shinydoofy 2013-07-27 18:50:07 UTC
That way it indeed works. Had to clone it, apply your patch and run make dist to get the patched tarball.

The README cleared up this one as well. Thanks for the pointers!
Comment 13 Alexander Tsoy 2013-07-27 20:36:56 UTC
+	local compatdir="$(_bash-completion-r1_get_bashdir compatdir /etc/bash_completion.d)"
...
+	insinto "${compatdir}"

It's better to do "insinto /etc/bash_completion.d" and not call private functions from eclass of course. :)
Comment 14 Florian Manschwetus 2013-07-29 15:47:50 UTC
sorry but could someone explain howto to get back a working bashcompletion?
Comment 15 Ryan Hill (RETIRED) gentoo-dev 2013-07-30 01:38:35 UTC
http://git.overlays.gentoo.org/gitweb/?p=proj/gentoo-bashcomp.git;a=commit;h=454d3250f82f1bc29d0f27b386dd63d54cd2e0de

I have a few other fixes to make for some recent portage changes (bug #478444) but I will try to get a new release done by the end of the week.
Comment 16 Ryan Hill (RETIRED) gentoo-dev 2013-08-04 19:38:14 UTC
Fixed in gentoo-bashcomp-20130804.
Comment 17 Evgeny Bobkin 2013-08-09 09:01:09 UTC
Thank you.