Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 476800 - media-video/qgifer - A video-based animated GIF creator.
Summary: media-video/qgifer - A video-based animated GIF creator.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: ChaosEngine
URL: https://sourceforge.net/projects/qgifer/
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2013-07-14 09:31 UTC by ChaosEngine
Modified: 2013-07-14 16:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (qgifer-0.2.1-r91.ebuild,530 bytes, text/plain)
2013-07-14 09:38 UTC, ChaosEngine
Details
Manifest (Manifest,1.48 KB, text/plain)
2013-07-14 09:39 UTC, ChaosEngine
Details
metadata - possible maintainer change (metadata.xml,589 bytes, text/xml)
2013-07-14 09:40 UTC, ChaosEngine
Details
patch (qgifer-0.2.1_desktop.patch,522 bytes, patch)
2013-07-14 09:40 UTC, ChaosEngine
Details | Diff
imagemagick? ( media-gfx/imagemagick:0 ) (qgifer-0.2.1-r91.ebuild,878 bytes, text/plain)
2013-07-14 14:59 UTC, ChaosEngine
Details
imagemagick change in metadata.xml (metadata.xml,510 bytes, text/xml)
2013-07-14 15:00 UTC, ChaosEngine
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ChaosEngine 2013-07-14 09:31:42 UTC
New ebuild for Qgifer, a video-based animated GIF creator.
Project looks very nice and useful, it's actively developed and hosted on sourceforge.
I'd like to support this ebuild through proxy maintainer.

Reproducible: Always

Steps to Reproduce:
1. emerge -v media-video/qgifer
2. qgifer
3.



Depends upon media-libs/giflib and media-libs/opencv
Comment 1 ChaosEngine 2013-07-14 09:38:45 UTC
Created attachment 353260 [details]
ebuild
Comment 2 ChaosEngine 2013-07-14 09:39:49 UTC
Created attachment 353262 [details]
Manifest
Comment 3 ChaosEngine 2013-07-14 09:40:23 UTC
Created attachment 353264 [details]
metadata - possible maintainer change
Comment 4 ChaosEngine 2013-07-14 09:40:44 UTC
Created attachment 353266 [details, diff]
patch
Comment 5 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-07-14 12:01:12 UTC
Listed you as the primary maintainer.

Sorted KEYWORDS. Added dependency on dev-qt/qtgui:4 (as it is listed in `objdump -p /usr/bin/qgifer`), slotted all dependencies; added ffmpeg USE on opencv otherwise you can't open any videos which would render the program completely useless, the user however can decide which codecs are supported by changing the USE flags of ffmpeg / libav. Added virtual/ffmpeg:0 as a dependency as well, because it makes calls to it:

src/converterdialog.cpp:     proc->start("ffmpeg", args);
src/mainwindow.h:     bool checkFFMPEG(){return !QProcess::execute("ffmpeg -version");}

When we look a bit further we also see the following so we depend on media-gfx/imagemagick:0 as well:

src/optimizerdialog.cpp:     proc->start(set->value("convert_exec","convert").toString(), args);

Moved patch to PATCHES array to remove src_prepare. Added debug USE flag and src_configure phase to support debugging. Other minor changes.

No idea why aidecoe is in the metadata, but if he planned to be a maintainer he'll have to add himself again; but well, I assume you copied this from somewhere.

+  14 Jul 2013; Tom Wijsman <TomWij@gentoo.org>
+  +files/qgifer-0.2.1-desktop.patch, +metadata.xml, +qgifer-0.2.1.ebuild:
+  New package for media-video/qgifer, a video-based animated GIF creator. Fixed
+  bug #476800, reported by Andrzej Pauli (ChaosEngine) which contributed this
+  and will maintain it.

Thank you for your contribution!

If you have any questions, feel free to ask.
Comment 6 ChaosEngine 2013-07-14 14:57:28 UTC
Excellent observations! Dindn't catch that qtgui and ffmpeg :-)
However I would give options to user to choose dependencies more lightly:

IUSE="debug imagemagick"
...
imagemagick? ( media-gfx/imagemagick:0 ) 

In case of ffmpeg, there is strict dependency (as you noticed) but imagemagick is optional according to this code:

qgifer-code/src/optimizerdialog.cpp

> void OptimizerDialog::checkIM()
> {    
>      bool c = convertAvailable();
>      if(!c)
>      {
>       msgLabel->setStyleSheet("color: red; font-size: 11pt");
>       msgLabel->setText(tr("Error: this operation requires the ImageMagick installed on your system. Please install ImageMagick or choose the directory with \"convert\" executable file."));

I've attached changes into this bug

PS.As of aidecoe - yes, I've copied his entries, because I thought He would be committing it to repo.
Comment 7 ChaosEngine 2013-07-14 14:59:06 UTC
Created attachment 353276 [details]
imagemagick? ( media-gfx/imagemagick:0 )

imagemagick as an option
Comment 8 ChaosEngine 2013-07-14 15:00:00 UTC
Created attachment 353278 [details]
imagemagick change in metadata.xml
Comment 9 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-07-14 15:50:16 UTC
(In reply to ChaosEngine from comment #6)
> PS.As of aidecoe - yes, I've copied his entries, because I thought He would
> be committing it to repo.

Oh, where did this ebuild come from? I didn't see it when looking in overlays; unless it has been recently added somewhere, I think I didn't sync recently.

Changes committed:

+  14 Jul 2013; Tom Wijsman <TomWij@gentoo.org> metadata.xml,
+  qgifer-0.2.1.ebuild:
+  Made imagemagick dependency optional with USE flag imagemagick, proxied commit
+  for Andrzej Pauli (ChaosEngine); as remarked in bug #476800.
Comment 10 ChaosEngine 2013-07-14 16:16:06 UTC
> Oh, where did this ebuild come from? I didn't see it when looking in overlays; unless it has been recently added somewhere, I think I didn't sync recently.

It's not important at this stage. Hi is, so to speak, my local irc gentoo developer contact :-)