Bug 473308 – "ROOT=/somewhere eselect set editor vi" is successful but returns 1 (should return 0)

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description smkbot 2013-06-14 19:58:07 UTC]

Running eselect set editor with a ROOT value other than / runs successfully but returns 1, instead of returning 0 as expected

Reproducible: Always

Steps to Reproduce:
1. ROOT=/somewhere eselect set editor vi
2. echo ${?}
Actual Results:  
1


Proposed fix:




diff -Naur eselect-1.3.4/libs/editor-variable.bash.in eselect-1.3.4-patched/libs/editor-variable.bash.in
--- eselect-1.3.4/libs/editor-variable.bash.in  2013-01-03 16:45:03.000000000 -0800
+++ eselect-1.3.4-patched/libs/editor-variable.bash.in  2013-06-14 12:47:57.732639270 -0700
@@ -157,6 +157,7 @@
        do_action env update noldconfig
        [[ ${ROOT:-/} = / ]] && echo \
                "Run \". ${EROOT}/etc/profile\" to update the variable in your shell."
+       return 0
 }
 
 ### update action ###

[Comment 1 Ulrich Müller 2013-07-07 12:31:33 UTC]

Fixed in git:
<http://git.overlays.gentoo.org/gitweb/?p=proj/eselect.git;a=commit;h=eeb450b9979960112388251e725ce4f6c70f184f>

[Comment 2 Ulrich Müller 2013-07-16 16:08:06 UTC]

Fixed in eselect-1.3.7.
Thanks for reporting!