Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 471522 - media-gfx/comix-4.0.4 fails to build with dev-python/pillow-2.0.0
Summary: media-gfx/comix-4.0.4 fails to build with dev-python/pillow-2.0.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL: https://sourceforge.net/p/comix/patch...
Whiteboard:
Keywords:
Depends on:
Blocks: 471488
  Show dependency tree
 
Reported: 2013-05-28 02:54 UTC by Mike Gilbert
Modified: 2014-02-13 14:22 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for pillow and virtual/python-imaging compatibility (comix-4.0.4-pillow.patch,3.57 KB, patch)
2013-06-16 17:50 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff
proposed comix-4.0.4-r1.ebuild (comix-4.0.4-r1.ebuild,1.80 KB, text/plain)
2013-06-16 18:57 UTC, Alexandre Rostovtsev (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2013-05-28 02:54:19 UTC
See the tracker bug 471488 for a solution.

 * Package:    media-gfx/comix-4.0.4
 * Repository: gentoo
 * Maintainer: graphics@gentoo.org
 * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux multilib policykit userland_GNU
 * FEATURES:   fakeroot preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
>>> Unpacking comix-4.0.4.tar.gz to /tmp/portage/media-gfx/comix-4.0.4/work
>>> Source unpacked in /tmp/portage/media-gfx/comix-4.0.4/work
>>> Preparing source in /tmp/portage/media-gfx/comix-4.0.4/work/comix-4.0.4 ...
 * Converting shebang in 'install.py'
 * Converting shebang in 'mime/comicthumb'
 * Converting shebang in 'src/comix.py'
>>> Source prepared.
>>> Configuring source in /tmp/portage/media-gfx/comix-4.0.4/work/comix-4.0.4 ...
>>> Source configured.
>>> Compiling source in /tmp/portage/media-gfx/comix-4.0.4/work/comix-4.0.4 ...
>>> Source compiled.
>>> Test phase [not enabled]: media-gfx/comix-4.0.4

>>> Install comix-4.0.4 into /tmp/portage/media-gfx/comix-4.0.4/image/ category media-gfx
Checking dependencies ...

Required dependencies:
    PyGTK ........................ OK
    !!! Python Imaging Library ... Not found

Recommended dependencies:
    rar/unrar .................... OK

Could not find all required dependencies!
Please install them and try again.
 * ERROR: media-gfx/comix-4.0.4 failed (install phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  93:  Called src_install
 *   environment, line 3315:  Called die
 * The specific snippet of code:
 *       python2 install.py install --no-mime --dir "${D}"usr || die;
 * 
 * If you need support, post the output of `emerge --info '=media-gfx/comix-4.0.4'`,
 * the complete build log and the output of `emerge -pqv '=media-gfx/comix-4.0.4'`.
 * The complete build log is located at '/var/log/portage/media-gfx:comix-4.0.4:20130528-024825.log'.
 * For convenience, a symlink to the build log is located at '/tmp/portage/media-gfx/comix-4.0.4/temp/build.log'.
 * The ebuild environment file is located at '/tmp/portage/media-gfx/comix-4.0.4/temp/environment'.
 * Working directory: '/tmp/portage/media-gfx/comix-4.0.4/work/comix-4.0.4'
 * S: '/tmp/portage/media-gfx/comix-4.0.4/work/comix-4.0.4'
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-06-16 17:50:14 UTC
Created attachment 351132 [details, diff]
patch for pillow and virtual/python-imaging compatibility

Submitted upstream at https://sourceforge.net/p/comix/patches/50/
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-06-16 18:57:58 UTC
Created attachment 351144 [details]
proposed comix-4.0.4-r1.ebuild

Modernized and fixed ebuild:
* EAPI5
* python-single-r1.eclass (not python-r1.eclass because it would take a bit of patching to make /usr/bin/comix work with multiple python ABIs).
* l10n.eclass for translation handling
* properly update xdg mime, .desktop, gtk icon, and gconf databases in postinst/postrm (see gnome2.eclass)
Comment 3 Mike Gilbert gentoo-dev 2013-06-16 19:06:33 UTC
Looks good to me.

Maybe replace the direct "python" call in src_install with "${PYTHON}" to invoke the correct interpreter directly.
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-06-16 19:31:48 UTC
(In reply to Mike Gilbert from comment #3)
> Maybe replace the direct "python" call in src_install with "${PYTHON}" to
> invoke the correct interpreter directly.

I don't think that would be needed: python-single-r1_pkg_setup exports EPYTHON, so /usr/bin/python (which is a symlink to python-wrapper) will automatically choose the appropriate versioned python executable.
Comment 5 Mike Gilbert gentoo-dev 2013-06-16 19:41:55 UTC
(In reply to Alexandre Rostovtsev from comment #4)

Correct, it is not necessary. However, it would be slightly more efficient to call the appropriate python interpreter directly.
Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-08-15 02:44:50 UTC
Thanks for the review.

Fixed by a non-maintainer commit (bug is almost 3 months old) with the recommended "${PYTHON}" change.

+*comix-4.0.4-r1 (15 Aug 2013)
+
+  15 Aug 2013; Alexandre Rostovtsev <tetromino@gentoo.org>
+  +comix-4.0.4-r1.ebuild, +files/comix-4.0.4-pillow.patch:
+  Non-maintainer commit (bug #471522): fix compatibility with
+  virtual/python-imaging; update to EAPI5 and python-single-r1.eclass; update
+  mime, icon, .desktop etc. databases in postinst/postrm.