Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 470990 - dev-python/Djblets: migrate to distutils-r1
Summary: dev-python/Djblets: migrate to distutils-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 471186
Blocks:
  Show dependency tree
 
Reported: 2013-05-22 10:46 UTC by Michael Palimaka (kensington)
Modified: 2013-06-15 11:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Djblets-0.7.14-r1.patch (Djblets-0.7.14-r1.patch,2.14 KB, patch)
2013-05-22 10:46 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2013-05-22 10:46:15 UTC
Created attachment 348894 [details, diff]
Djblets-0.7.14-r1.patch

Attached is a suggested patch.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2013-05-28 06:20:08 UTC
any finality on this need await the move from moving pillow to imaging by name
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2013-06-13 08:09:04 UTC
+python_install() {
+	rm -rf "${BUILD_DIR}"/lib/tests tests || die

It's better to have tests deleted before getting to install phase.  There have been a few packages recently where setup.py is patched in order to not treat a test(s) folder as a 'package', a package being a module that gets installed by distutils' setuptools.  The patch's action is to remove tests from packages=(..).  Alternately, you can remove the tests folder on completion of running them in python_test, combined with adding {if ! use test then remove tests folder} in the compile phase.  

local msg="Remove un-needed tests and also avoid file collisions"

This is worth keeping and running because NOT ALL test(s) folders on install trigger file collisions
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2013-06-15 11:49:27 UTC
like so;

  15 Jun 2013; Ian Delaney <idella4@gentoo.org> +Djblets-0.7.15.ebuild,
  +files/exclude-tests.patch, Djblets-0.6.22.ebuild, Djblets-0.7.14.ebuild:
  revbump, migrate -> distutils-r1, bump, patch to exclude tests from install,
  add all req'd deps, closes Bug No.s 470990 473088"

The exclusion of tests is made a necessity by distutils-r1