Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 470812 - x11-misc/dmenu-4.5-r2 [xft]: wrong encoding for some fonts
Summary: x11-misc/dmenu-4.5-r2 [xft]: wrong encoding for some fonts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-20 17:20 UTC by Eduardo Suarez-Santana
Modified: 2013-05-23 03:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed xft patch (dmenu-4.5-xft-edu.patch,12.63 KB, patch)
2013-05-20 17:23 UTC, Eduardo Suarez-Santana
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Suarez-Santana 2013-05-20 17:20:30 UTC
There are cases where the xft unofficial patch for dmenu renders the text with the wrong encoding. This happens when no xft font is loaded.

Reproducible: Always

Steps to Reproduce:
1. Install dmenu with xft use flag
2. Run on terminal: echo áóéí | dmenu
3. Watch the rendered text.
Actual Results:  
The rendered text is in the wrong encoding.

Expected Results:  
The rendered text to look as 'áóéí'.

Without xft patch
$ echo áóéí | dmenu -> OK

With xft patch
$ echo áóéí | dmenu -> fails
$ echo áóéí | dmenu -fn "Terminus-10:normal" -> OK
Comment 1 Eduardo Suarez-Santana 2013-05-20 17:23:30 UTC
Created attachment 348772 [details, diff]
Proposed xft patch

This patch is supossed to substitute the already existing patch for xft.

The patch proposes to switch the order of 'if' sentences in 'initfont'/'loadfont' functions.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-05-20 18:11:49 UTC
Comment on attachment 348772 [details, diff]
Proposed xft patch

I'd rather fix this in the ebuild as upstream is pretty sure to not accept patches that use pkgconfig...
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2013-05-20 18:31:20 UTC
While working on this, I saw that USE=xinerama is broken too - it actually requires that we add

    append-cflags -DXINERAMA

for it to work as intended.

Also, your patch doesn't actually change anything compared to the patch we already apply, except the config.mk stuff which I am working on getting fixed in the ebuild.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2013-05-20 19:52:41 UTC
(In reply to comment #3)
> Also, your patch doesn't actually change anything compared to the patch we
> already apply, except the config.mk stuff which I am working on getting
> fixed in the ebuild.

I may have missed some bits there in my initial review. Apart from the config.mk/pkg-config changes, I think your patch should probably be reviewed upstream.
Comment 5 Eduardo Suarez-Santana 2013-05-20 19:57:55 UTC
I didn't any changes to config.mk compared to the existing patch.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2013-05-23 03:31:13 UTC
Let's give this a spin. The patch is at work in 4.5-r3.