Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469670 - net-p2p/bitcoind: add systemd unit
Summary: net-p2p/bitcoind: add systemd unit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: install-systemd-unit
  Show dependency tree
 
Reported: 2013-05-13 09:54 UTC by Alexander Tsoy
Modified: 2013-07-27 07:26 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bitcoind-0.8.1.ebuild.patch (bitcoind-0.8.1.ebuild.patch,878 bytes, patch)
2013-05-13 09:55 UTC, Alexander Tsoy
Details | Diff
bitcoind.service (bitcoind.service,869 bytes, text/plain)
2013-05-13 09:55 UTC, Alexander Tsoy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2013-05-13 09:54:55 UTC
net-p2p/bitcoind should provide systemd unit file.

Reproducible: Always
Comment 1 Alexander Tsoy 2013-05-13 09:55:16 UTC
Created attachment 348144 [details, diff]
bitcoind-0.8.1.ebuild.patch
Comment 2 Alexander Tsoy 2013-05-13 09:55:38 UTC
Created attachment 348146 [details]
bitcoind.service
Comment 3 Alexander Tsoy 2013-05-13 09:58:39 UTC
(In reply to comment #2)
> Created attachment 348146 [details]
> bitcoind.service

Without "-daemon=0" option users could add "daemon=1" in bitcoind.conf and this will break the unit (daemon=1 require Type=forking).
Comment 4 Luke-Jr 2013-05-14 19:32:29 UTC
Surely there should be a USE flag controlling this? I don't want systemd clutter on my system, at least, and I doubt many others do.
Comment 5 Anthony Basile gentoo-dev 2013-05-14 19:34:46 UTC
(In reply to comment #4)
> Surely there should be a USE flag controlling this? I don't want systemd
> clutter on my system, at least, and I doubt many others do.

Yeah, that's the debate on gentoo-dev@.  I'm thinking unconditionally install and limit with INSTALL_MASK.

Leave this open until the dust settles.
Comment 6 Alexander Tsoy 2013-05-21 16:42:23 UTC
(In reply to comment #4)
> I don't want systemd clutter on my system, at least, and I doubt many others do.

You likely already have several systemd units installed on your system. ;)
Comment 7 Pacho Ramos gentoo-dev 2013-07-20 13:18:20 UTC
I will commit in a week if nobody disagrees (also CCing systemd team to let them review the unit files)
Comment 8 Luke-Jr 2013-07-20 18:48:38 UTC
(In reply to Pacho Ramos from comment #7)
> I will commit in a week if nobody disagrees (also CCing systemd team to let
> them review the unit files)

I still disagree, and see no reason to change that...
Comment 9 Pacho Ramos gentoo-dev 2013-07-20 18:52:35 UTC
(In reply to Luke-Jr from comment #8)
> (In reply to Pacho Ramos from comment #7)
> > I will commit in a week if nobody disagrees (also CCing systemd team to let
> > them review the unit files)
> 
> I still disagree, and see no reason to change that...

This disagreement isn't valid as the question of installing a single file depending on a USE flag has been discussed a lot and what you need to do is to use INSTALL_MASK
Comment 10 Luke-Jr 2013-07-20 18:55:07 UTC
(In reply to Pacho Ramos from comment #9)
> (In reply to Luke-Jr from comment #8)
> > (In reply to Pacho Ramos from comment #7)
> > > I will commit in a week if nobody disagrees (also CCing systemd team to let
> > > them review the unit files)
> > 
> > I still disagree, and see no reason to change that...
> 
> This disagreement isn't valid as the question of installing a single file
> depending on a USE flag has been discussed a lot and what you need to do is
> to use INSTALL_MASK

That's why we have USE=bash-completion?
Comment 11 Luke-Jr 2013-07-20 18:55:59 UTC
(In reply to Luke-Jr from comment #10)
> (In reply to Pacho Ramos from comment #9)
> > (In reply to Luke-Jr from comment #8)
> > > (In reply to Pacho Ramos from comment #7)
> > > > I will commit in a week if nobody disagrees (also CCing systemd team to let
> > > > them review the unit files)
> > > 
> > > I still disagree, and see no reason to change that...
> > 
> > This disagreement isn't valid as the question of installing a single file
> > depending on a USE flag has been discussed a lot and what you need to do is
> > to use INSTALL_MASK
> 
> That's why we have USE=bash-completion?

In fact, not using USE flags just because it's a single file adds up to a LOT of "single files" after a while... Unlike INSTALL_MASK, USE flags can be disabled by default.
Comment 12 Pacho Ramos gentoo-dev 2013-07-20 18:58:28 UTC
(In reply to Luke-Jr from comment #10) 
> That's why we have USE=bash-completion?

Because that packages are using obsolete eclass instead of new eclass that don't add that flag, the same occurs for logrotate case:
https://bugs.gentoo.org/show_bug.cgi?id=198901
Comment 13 Pacho Ramos gentoo-dev 2013-07-27 07:26:55 UTC
+*bitcoind-0.8.3-r1 (27 Jul 2013)
+
+  27 Jul 2013; Pacho Ramos <pacho@gentoo.org> +bitcoind-0.8.3-r1.ebuild,
+  +files/bitcoind.service:
+  Install unit file #469670
+