Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 469664 - [Future EAPI] new ebuild stage - src_patch
Summary: [Future EAPI] new ebuild stage - src_patch
Status: RESOLVED DUPLICATE of bug 463768
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: PMS/EAPI
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-13 09:31 UTC by Hristo Venev
Modified: 2013-05-13 09:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hristo Venev 2013-05-13 09:31:24 UTC
I am extremely frustrated with the ~11000 ebuilds not invoking epatch_user.
Therefore I propose a new ebuild stage - src_patch. All patching should be moved from src_prepare to src_patch.

1. src_unpack
2. src_patch
3. epatch_user
4. src_prepare
5. src_configure
6. src_compile
7. src_test?
8. src_install

epatch_user is done after src_patch because user patches may revert ones in the tree.  Also it's done before src_prepare because the user patches may modify configure.ac/Makefile.am/other files used during src_prepare.

Also, ebuilds may use EPATCH= with their own src_prepare.

Reproducible: Always
Comment 1 Hristo Venev 2013-05-13 09:34:17 UTC
s/EPATCH=/PATCHES=/
sorry
Comment 2 Ulrich Müller gentoo-dev 2013-05-13 09:47:12 UTC
The crucial point is that a substitute for epatch has to be included in the package manager. The lack of an implementation for this was the reason that PM support for epatch_user didn't make it into EAPI 5, see <http://wiki.gentoo.org/wiki/EAPI_5_tentative_features>.

Closing as duplicate of bug 463768, because it makes more sense to discuss the issue at one single place. (Besides, introducing a new phase function in the next EAPI won't fix any of the existing ebuilds.)

*** This bug has been marked as a duplicate of bug 463768 ***