Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 468930 - net-misc/networkmanager: detect consolekit/logind at runtime
Summary: net-misc/networkmanager: detect consolekit/logind at runtime
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks: systemd-love
  Show dependency tree
 
Reported: 2013-05-07 19:50 UTC by Fabio Erculiani (RETIRED)
Modified: 2013-07-27 06:54 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
consolekit/logind runtime detection for 0.9.6.x (0001-core-runtime-detect-logind-and-ConsoleKit.patch,40.60 KB, patch)
2013-05-07 19:51 UTC, Fabio Erculiani (RETIRED)
Details | Diff
consolekit/logind runtime detection for 0.9.8.x (0001-core-runtime-detect-logind-and-ConsoleKit-2.patch,26.25 KB, patch)
2013-05-07 19:51 UTC, Fabio Erculiani (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2013-05-07 19:50:47 UTC
I made a patch (that could be upstreamed) that makes possible to move the logind/consolekit detection to runtime (from build time).
One version of the patch applies to 0.9.6.x while the other one to 0.9.8.x.

I am willing to maintain it as long as we keep supporting consolekit and if upstream is not interested.

Reproducible: Always
Comment 1 Fabio Erculiani (RETIRED) gentoo-dev 2013-05-07 19:51:18 UTC
Created attachment 347630 [details, diff]
consolekit/logind runtime detection for 0.9.6.x
Comment 2 Fabio Erculiani (RETIRED) gentoo-dev 2013-05-07 19:51:38 UTC
Created attachment 347632 [details, diff]
consolekit/logind runtime detection for 0.9.8.x
Comment 3 Pacho Ramos gentoo-dev 2013-05-11 09:57:33 UTC
Upstreamed:
https://bugzilla.gnome.org/show_bug.cgi?id=700118
Comment 4 Pacho Ramos gentoo-dev 2013-05-11 11:32:24 UTC
Fabio, upstream pointed me to:
https://bugzilla.gnome.org/show_bug.cgi?id=686997

They are happy to allow the runtime detection, but some suggestions need to be handled:
https://bugzilla.gnome.org/show_bug.cgi?id=686997#c6
Comment 5 Pavel Šimerda 2013-05-11 12:00:30 UTC
(In reply to comment #4)
> Fabio, upstream pointed me to:
> https://bugzilla.gnome.org/show_bug.cgi?id=686997
> 
> They are happy to allow the runtime detection, but some suggestions need to
> be handled:
> https://bugzilla.gnome.org/show_bug.cgi?id=686997#c6

Upstream is happy to cooperate and provide distributions with as patch-free experience as possible. At least one upstream developer (me) is using Gentoo on his development machine.
Comment 6 Fabio Erculiani (RETIRED) gentoo-dev 2013-05-11 12:27:54 UTC
Please note that I'll be a bit slow to respond to patch reviews during this month due to IRL, so you could either be patient and wait until June or just take my patch and fix it where needed :)
Comment 7 Fabio Erculiani (RETIRED) gentoo-dev 2013-07-11 10:12:08 UTC
I updated the patches on the upstream bug
Comment 8 Pacho Ramos gentoo-dev 2013-07-27 06:54:46 UTC
*networkmanager-0.9.8.2-r2 (15 Jul 2013)

  15 Jul 2013; Pacho Ramos <pacho@gentoo.org> +networkmanager-0.9.8.2-r2.ebuild,
  -files/0001-core-runtime-detect-logind-and-ConsoleKit-3.patch,
  -networkmanager-0.9.8.2-r1.ebuild:
  Revision bump dropping runtime detect of logind as we won't be able to support
  logind without systemd being running, and this keeps us more close to upstream
  (preventing us from hitting any hypothetical problems that could arise from it
  until accepted by upstream). Also force dhcpcd < 6 until upstream confirms
  updating configure check is enough to properly work with newer versions.