Bug 468580 – sys-apps/busybox should use REQUIRED_USE to stop users from combining USE="static pam"

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kobboi 2013-05-04 14:22:17 UTC]

The current ebuild does not support setting USE=pam and USE=static. This is currently handled within src_configure()

        if use static && use pam ; then
                ewarn "You cannot have USE='static pam'.  Assuming static is more important."
        fi

However, the merge is recorded as +static and +pam. 

$ eix busybox
[I] sys-apps/busybox
     Available versions:  1.19.3-r1^t (~)1.20.0^t 1.20.1^t 1.20.2^t (~)1.21.0^t **9999^t {ipv6 livecd make-symlinks math mdev -pam savedconfig selinux sep-usr (+)static syslog systemd ELIBC="glibc"}
     Installed versions:  1.21.0^t(04:12:35 PM 05/04/2013)(ipv6 pam static systemd -livecd -make-symlinks -math -mdev -savedconfig -selinux -sep-usr -syslog)
     Homepage:            http://www.busybox.net/
     Description:         Utilities for rescue and embedded systems

Since this ebuild is EAPI=4, I think we should use the REQUIRED_USE variable as explained on

http://devmanual.gentoo.org/ebuild-writing/eapi/

Reproducible: Always

[Comment 1 SpanKY 2013-05-08 02:52:43 UTC]

the default build is USE='pam static' which means REQUIRED_USE will break the build for everyone

package.use in the profile would need tweaking before it be allowed

even, then i'm not sure it's worthwhile.  few people care about USE=pam w/bb.

[Comment 2 Erik Quaeghebeur 2013-09-12 16:17:42 UTC]

(In reply to SpanKY from comment #1)
> the default build is USE='pam static' which means REQUIRED_USE will break
> the build for everyone
> 
> package.use in the profile would need tweaking before it be allowed
> 
> even, then i'm not sure it's worthwhile.  few people care about USE=pam w/bb.

Shouldn't the default in the profiles then be USE='static'? I got the warning when updating busybox-1.21.0 even though I have nowhere altered the pam and/or static use flags (generally and for busybox). So I guess everybody gets this warning.

[Comment 3 SpanKY 2013-12-31 07:58:31 UTC]

(In reply to Erik Quaeghebeur from comment #2)

there's no way we'd want the profile to globally do USE=static by default.  we do however want busybox itself to default to USE=static as it is the system rescue shell.

[Comment 4 Peter Weilbacher 2015-06-20 14:50:19 UTC]

If you don't want to solve the problem in any other way than is currently done, could you please at least remove the ewarn from the ebuild? It's really confusing to users that they get this warning when (re-)emerging busybox. Especially because the phrasing ("You cannot have USE='static pam'") suggests that they did something wrong, have set up unusual (bad?) USE flags, etc., and some (like me) may spend a lot of time to research the problem. I would gladly file another bug for this, if it helps...

[Comment 5 SpanKY 2015-11-13 05:36:19 UTC]

since USE=pam is set in make.defaults in the profile, and package.use is able to override that by default, we can set USE='static -pam' in it.  which then allows us to leverage REQUIRED_USE as only users who explicitly opt in to USE=pam will be affected.

for now, it's only in the 9999 ebuild.  if things go well, it'll go out in the next release version.

http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a88ace55b415065fd71800db672557e54e065969