Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 466030 - app-editors/nvi-1.81.6-r3: various wide character bugs with USE=unicode
Summary: app-editors/nvi-1.81.6-r3: various wide character bugs with USE=unicode
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Felix Janda
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on: 690102
Blocks:
  Show dependency tree
 
Reported: 2013-04-15 22:03 UTC by Maks Verver
Modified: 2019-08-03 08:31 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix several --enable-widechar bugs (nvi-1.81.6-widechar.patch,34.40 KB, patch)
2013-04-15 22:04 UTC, Maks Verver
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maks Verver 2013-04-15 22:03:30 UTC
The current nvi port still contains a lot of bugs related to wide character support that is enabled by the unicode-useflag.  (For example, using the '#' command crashes nvi even in all-ASCII files.)

I noticed Sven Verdoolaege's Git repository (see: http://repo.or.cz/w/nvi.git) already contains fixes for a lot of these issues; I've collected the relevant changes into a big patch file that I'll attach.

Would a developer please give this a quick look at this and then update the ebuild to apply this patch?

Reproducible: Always

Steps to Reproduce:
nvi
a123^[
^#+
Actual Results:  
Segmentation fault


Expected Results:  
124
Comment 1 Maks Verver 2013-04-15 22:04:38 UTC
Created attachment 345646 [details, diff]
Patch to fix several --enable-widechar bugs
Comment 2 Jesus Rivero (RETIRED) gentoo-dev 2013-12-31 16:49:20 UTC
(In reply to Maks Verver from comment #1)
> Created attachment 345646 [details, diff] [details, diff]
> Patch to fix several --enable-widechar bugs

Hi Maks, 

Thanks for taking the time and doing this. However, this is a major patch and I wonder how much have you actually tested it. Do you use NVI regularly? for how long have you used it with this patch?

I'd probably release a masked version of NVI with this patch an see if it doesn't break anything else. 

Thanks!
Comment 3 Maks Verver 2014-01-01 21:34:10 UTC
I've been using the patched version for half a year without problems, and although I do use vi quite a lot, I cannot guarantee my typical usage patterns provide adequate test coverage.

Since the current version in portage has known problems, I would say it makes more sense to add the patch and deal with whatever problems arise than to keep a known-buggy version around.  The changes in the patch seem sensible enough, so I wouldn't expect too many complications.
Comment 4 Virgil Dupras gentoo-dev 2018-09-29 00:18:19 UTC
Felix, you're the maintainer of this package. Have you reviewed this patch?
Comment 5 Jonas Stein gentoo-dev 2019-06-01 13:46:51 UTC
I could not reproduce the report. Please provide the requested information.
Comment 6 Jonas Stein gentoo-dev 2019-06-01 13:48:58 UTC
felix, could you reproduce it?
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-08-03 08:31:33 UTC
Ping.