Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464848 - x11-base/xorg-server: /etc/init.d/xdm should be able to read DM settings from external files
Summary: x11-base/xorg-server: /etc/init.d/xdm should be able to read DM settings from...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-06 12:23 UTC by Pacho Ramos
Modified: 2013-05-26 19:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2013-04-06 12:23:44 UTC
https://bugs.gentoo.org/show_bug.cgi?id=463784

shows that current way of handling DMs in init.d script is pretty inflexible. For example, we would need different settings depending on people running gdm-3.x or gdm-2.x. 

I think would be better if init.d script could read needed variables from external files installed by each DMs ebuilds.

Would be possible to do that?

Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2013-04-22 19:13:02 UTC
Any updates on this? Also, looks a bit strange to me the need of update/re-emerge xorg-server for changes in init.d scripts, probably a different package could be used to carry on init.d scripts :/
Comment 2 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-04-22 20:54:37 UTC
I think the init scripts were part of xinit before. Not sure why they were moved to xorg-server, that predates my involvement in Gentoo.
Comment 3 Pacho Ramos gentoo-dev 2013-04-23 06:30:23 UTC
*xorg-server-1.8.0 (13 Apr 2010)

  13 Apr 2010; Tomáš Chvátal <scarabeus@gentoo.org>
  +files/1.8.0-match-only-sane-devices.patch, +xorg-server-1.8.0.ebuild,
  +files/1.8.0-no-hardcoded-etc.patch, +files/xdm-setup.initd-1,
  +files/xdm.confd-3, +files/xdm.initd,
  +files/xorg-server-disable-acpi.patch, metadata.xml:
  Version bump to xorg-server 1.8.

Looks like this was the change, maybe scarabeus knows more about it :/
Comment 4 Pacho Ramos gentoo-dev 2013-04-27 09:48:36 UTC
(In reply to comment #2)
> I think the init scripts were part of xinit before. Not sure why they were
> moved to xorg-server, that predates my involvement in Gentoo.

Some rationale in:
https://bugs.gentoo.org/show_bug.cgi?id=356915#c5

Anyway, I still think would be interesting to allow script to catch values from external files allowing us to install a file setting different "EXE", "START-STOP_ARGS" and "PIDFILE" values. For example, gdm-2.x will need different values than gdm-3.x, if gdm-3.x would install a simple file setting that variables, that would be nice
Comment 5 Pacho Ramos gentoo-dev 2013-05-02 08:00:50 UTC
If finally this is not implemented, we will need various xorg-server revisions providing updated xdm script with gdm-3.x support :/
Comment 6 Pacho Ramos gentoo-dev 2013-05-12 13:55:54 UTC
ping!
Comment 7 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-05-12 16:33:03 UTC
I am busy with other things currently. Feel free to make any necessary changes to the xdm init script, just keep an eye on bugzilla for user reports of breakage. If in doubt, you can ask us for review and/or commit under p.mask.
Comment 8 Pacho Ramos gentoo-dev 2013-05-12 16:35:41 UTC
(In reply to comment #7)
> I am busy with other things currently. Feel free to make any necessary
> changes to the xdm init script, just keep an eye on bugzilla for user
> reports of breakage. If in doubt, you can ask us for review and/or commit
> under p.mask.

The problem is that adapting init.d script to gdm3 will lead it incompatible with gdm2 if we don't make the big change of letting script to inherit variable values from files installed by DMs ebuilds :/

Also, would be much better to split scripts to a separate package (I would even have a package only for init.d script if we don't agree on what package should carry it), otherwise, I would need to revbump all xorg-server ebuilds to only change init.d script (and people would need to rebuild server only for that change)

I need then x11 team opinion on what they want to do
Comment 9 Pacho Ramos gentoo-dev 2013-05-26 19:12:57 UTC
We can delay this if X11 team prefers, will attach a patch to existing xdm init.d script in bug 463784 for x11 team review