Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464704 - media-libs/audiofile - Please add multilib ABI support
Summary: media-libs/audiofile - Please add multilib ABI support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: PATCH
Depends on: 464490 464702
Blocks: gx86-multilib
  Show dependency tree
 
Reported: 2013-04-05 10:33 UTC by Karl Lindén
Modified: 2013-05-02 12:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The proposed ebuild supporting multilib ABIs. (audiofile-0.3.6-r1.ebuild,1.25 KB, text/plain)
2013-04-05 10:33 UTC, Karl Lindén
Details
The new proposed ebuild supporting multilib ABIs. (audiofile-0.3.6-r1.ebuild,1.16 KB, text/plain)
2013-04-07 18:16 UTC, Karl Lindén
Details
Improved ebuild (audiofile-0.3.6-r1.ebuild,1.13 KB, text/plain)
2013-05-01 15:49 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Lindén 2013-04-05 10:33:47 UTC
Created attachment 344486 [details]
The proposed ebuild supporting multilib ABIs.

It would be great if media-libs/audiofile would have support for multilib ABIs so it can be dropped from app-emulation/emul-linux-x86-soundlibs in the future.

I'm attaching a working ebuild with multilib support through autotools-multilib.eclass. The tests are working fine for me, as long as I use dev-cpp/gtest with multilib support. It also needs media-libs/flac. Those bugs have to be fixed first.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2013-04-07 16:47:59 UTC
I'd much prefer the use of multilib-minimal eclass.
Comment 2 Pacho Ramos gentoo-dev 2013-04-07 16:56:15 UTC
run_in_build_dir from multibuild.eclass should help to simplify:
audiofile_src_test() {
	pushd "${BUILD_DIR}" > /dev/null || die
	emake -C test check
	popd > /dev/null || die
}

Probably something like:
src_test() {
	multilib_foreach_abi run_in_build_dir "emake -C test check"
}

could work, could you try?
Comment 3 Karl Lindén 2013-04-07 18:15:22 UTC
(In reply to comment #2)
> run_in_build_dir from multibuild.eclass should help to simplify:
> audiofile_src_test() {
> 	pushd "${BUILD_DIR}" > /dev/null || die
> 	emake -C test check
> 	popd > /dev/null || die
> }
> 
> Probably something like:
> src_test() {
> 	multilib_foreach_abi run_in_build_dir "emake -C test check"
> }
> 
> could work, could you try?

That makes it much simpler. Without the quotes though. It works the way it should. Thanks for the advice! I'm uploading the new ebuild.
Comment 4 Karl Lindén 2013-04-07 18:16:34 UTC
Created attachment 344738 [details]
The new proposed ebuild supporting multilib ABIs.
Comment 5 Pacho Ramos gentoo-dev 2013-04-07 18:26:07 UTC
(In reply to comment #1)
> I'd much prefer the use of multilib-minimal eclass.

Gilles, I have no problem with latest autotools-multilib ebuild, any reason for using multilib-minimal instead?
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-01 15:49:03 UTC
Created attachment 347052 [details]
Improved ebuild

I've just fixed autotools-utils_src_test to pass arguments to emake. This makes the test invocation much simpler ;).
Comment 7 Alexis Ballier gentoo-dev 2013-05-01 22:12:45 UTC
(In reply to comment #6)
> Created attachment 347052 [details]
> Improved ebuild

ok for me though I never really touched the package
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-02 12:50:47 UTC
Committed as 0.3.6-r1.