Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464594 - media-libs/libvorbis - Please add multilib ABI support.
Summary: media-libs/libvorbis - Please add multilib ABI support.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: EBUILD, PATCH, PMASKED
Depends on: 464486
Blocks: gx86-multilib 466608
  Show dependency tree
 
Reported: 2013-04-04 13:48 UTC by Karl Lindén
Modified: 2013-05-01 21:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The proposed ebuild. (libvorbis-1.3.3-r1.ebuild,991 bytes, text/plain)
2013-04-04 13:48 UTC, Karl Lindén
Details
A patch to honour the --docdir argument. (libvorbis-1.3.3-honour-docdir.patch,1.85 KB, patch)
2013-04-04 13:49 UTC, Karl Lindén
Details | Diff
Updated ebuild using autotools-multilib (libvorbis-1.3.3-r1.ebuild,1.09 KB, text/plain)
2013-05-01 13:51 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Lindén 2013-04-04 13:48:27 UTC
Created attachment 344376 [details]
The proposed ebuild.

Currently, media-libs/libvorbis does not support multilib ABIs. The 32-bit libraries are instead bundled in app-emulations/emul-linux-x86-soundlibs. The package media-libs/libvorbis should have multilib ABI support so that it can be removed from app-emulations/emul-linux-x86-soundlibs in future versions.

I'm attaching a proposed ebuild and necessary patch to honour the --docdir argument sent to the configure script. The patch is posted upstream [1].

Another new thing in the ebuild is of course a block on the emul-linux-x86-soundlibs package.

[1] https://trac.xiph.org/ticket/1945
Comment 1 Karl Lindén 2013-04-04 13:49:37 UTC
Created attachment 344378 [details, diff]
A patch to honour the --docdir argument.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-01 13:51:17 UTC
Created attachment 347046 [details]
Updated ebuild using autotools-multilib

@Karl, please file the docdir bug separately and preferably upstream as well.

@sound, please review the ebuild. It should be noted that it must be built against multilib libogg and not emul-linux (due to header wrapping need). Otherwise, the tests will just segfault :).
Comment 3 Karl Lindén 2013-05-01 19:08:25 UTC
(In reply to comment #2)
> Created attachment 347046 [details]
> Updated ebuild using autotools-multilib
> 
> @Karl, please file the docdir bug separately and preferably upstream as well.
> 
Reported as #468194.
Comment 4 Alexis Ballier gentoo-dev 2013-05-01 20:33:51 UTC
(In reply to comment #2)
> Created attachment 347046 [details]
> Updated ebuild using autotools-multilib

should be ok (its very similar to libogg anyway)
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-05-01 21:33:38 UTC
Committed as 1.3.3-r1, package.masked for now.