Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 463578 - app-admin/gtkdiskfree-2.0.1 fails to build due to underlinking
Summary: app-admin/gtkdiskfree-2.0.1 fails to build due to underlinking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Samuel Bauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: underlinking
  Show dependency tree
 
Reported: 2013-03-28 09:05 UTC by Patrick Lauer
Modified: 2013-08-21 07:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (gtkdiskfree-2.0.1-glibc-2.17_build.log,27.39 KB, text/x-log)
2013-07-18 18:22 UTC, Samuel Bauer
Details
gtkdiskfree-2.0.1-r1.ebuild (gtkdiskfree-2.0.1-r1.ebuild,924 bytes, text/plain)
2013-08-14 12:52 UTC, Samuel Bauer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2013-03-28 09:05:40 UTC
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.     -O2 -pipe -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng15 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2  -c pixmap.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.     -O2 -pipe -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng15 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2  -c options.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.     -O2 -pipe -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng15 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2  -c widgets.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.     -O2 -pipe -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng15 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2  -c utils.c
In file included from /usr/include/glib-2.0/gobject/gobject.h:30:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:31,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from /usr/include/glib-2.0/gio/gioenums.h:30,
                 from /usr/include/glib-2.0/gio/giotypes.h:30,
                 from /usr/include/glib-2.0/gio/gio.h:28,
                 from /usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /usr/include/gtk-2.0/gtk/gtk.h:32,
                 from main.h:117,
                 from widgets.c:21:
widgets.c: In function ‘widget_radio_add’:
widgets.c:437:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     (gpointer)val);
     ^
/usr/include/glib-2.0/gobject/gsignal.h:440:73: note: in definition of macro ‘g_signal_connect’
     g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
                                                                         ^
utils.c: In function ‘filutils_get_lines’:
utils.c:110:7: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
  fread(buffer, st.st_size, 1, f);
       ^
x86_64-pc-linux-gnu-gcc  -O2 -pipe -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng15 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2   -Wl,-O1 -Wl,--as-needed -o gtkdiskfree about.o configure.o diskfree.o interface.o main.o menus.o mount.o pixmap.o options.o widgets.o utils.o  -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfreetype -lfontconfig  
/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.0/../../../../x86_64-pc-linux-gnu/bin/ld: diskfree.o: undefined reference to symbol 'ceilf@@GLIBC_2.2.5'
/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.0/../../../../x86_64-pc-linux-gnu/bin/ld: note: 'ceilf@@GLIBC_2.2.5' is defined in DSO /lib64/libm.so.6 so try adding it to the linker command line
/lib64/libm.so.6: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
make[3]: *** [gtkdiskfree] Error 1
make[3]: Leaving directory `/var/tmp/portage/app-admin/gtkdiskfree-2.0.1/work/gtkdiskfree-master/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/app-admin/gtkdiskfree-2.0.1/work/gtkdiskfree-master/src'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/var/tmp/portage/app-admin/gtkdiskfree-2.0.1/work/gtkdiskfree-master/src'
make: *** [all-recursive] Error 1
 * ERROR: app-admin/gtkdiskfree-2.0.1 failed (compile phase):
 *   emake failed

Portage 2.1.11.59 (default/linux/amd64/13.0, gcc-4.8.0, glibc-2.16.0, 3.7.9-vs2.3.5.6 x86_64)
=================================================================
System uname: Linux-3.7.9-vs2.3.5.6-x86_64-AMD_Phenom-tm-_II_X4_965_Processor-with-gentoo-2.2
KiB Mem:     7921088 total,    774984 free
KiB Swap:   25165812 total,  24453784 free
Timestamp of tree: Unknown
ld GNU ld (GNU Binutils) 2.23.2
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.3-r3, 3.2.3-r2
dev-util/cmake:           2.8.10.2-r1
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.6, 1.12.6, 1.13.1
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.2-r1, 4.8.0::hardened-dev
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.8 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo sunrise hardened-dev
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/entropy /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/polkit-1/actions /usr/share/themes/oxygen-gtk/gtk-2.0 /var/lib/hsqldb"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://ftp.lecl.net/pub/gentoo/ http://ftp.lecl.net/pub/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/sunrise /var/lib/layman/hardened-development"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acl amd64 berkdb bzip2 cli cracklib crypt cxx dri egl fortran gdbm gpm iconv ipv6 mmx modules mudflap multilib ncurses nls nptl openmp openvg pam pcre readline session sqlite sse sse2 ssl tcpd unicode xa xvfb zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby19" USERLAND="GNU" VIDEO_CARDS="vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2013-03-29 10:49:23 UTC
This needs to be reported upstream.
Comment 2 Samuel Bauer 2013-04-10 19:39:14 UTC
Upstream is here, but for now i don't have internet connexion at home, my current glibc is stable (2.15-r3), I'll fetch the unstable (2.17), and try to fix this issue.
When I'll have opportunity to have an internet access from my laptop, i'll push the fix, and send a new ebuild (which I proxy-maintain).
Sorry, if it takes a while.
Comment 3 Samuel Bauer 2013-07-18 18:22:31 UTC
Created attachment 353606 [details]
build.log

The build worked fine for me, maybe the glibc patchset has been updated since the bug was opened. Maybe something in my test is missing, just try to notice it to me if you see something wrong.

Portage 2.1.12.2 (default/linux/amd64/13.0, gcc-4.6.3, glibc-2.17, 3.8.13-gentoo-nvidia x86_64)
=================================================================
System uname: Linux-3.8.13-gentoo-nvidia-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T9300_@_2.50GHz-with-gentoo-2.2
KiB Mem:     4045404 total,    420580 free
KiB Swap:    2711892 total,   2412148 free
Timestamp of tree: Mon, 15 Jul 2013 14:30:01 +0000
ld GNU ld (GNU Binutils) 2.23.1
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p45
dev-java/java-config:     2.1.12-r1
dev-lang/python:          2.7.5, 3.2.5-r1, 3.3.2-r1
dev-util/ccache:          3.1.9
dev-util/cmake:           2.8.10.2-r2
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.9.6-r3, 1.11.6, 1.12.6
sys-devel/binutils:       2.23.1
sys-devel/gcc:            4.4.7, 4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.7 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: sunrise science desktop-effects bircoph sabayon hasufell gentoo various sam
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/gentoo/files/distfiles"
EMERGE_DEFAULT_OPTS="--misspell-suggestions=n"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync metadata-transfer news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://gentoo.imj.fr/pub/gentoo/ http://www.mirrorservice.org/sites/www.ibiblio.org/gentoo/ http://ftp.daum.net/gentoo/ http://mirror.qubenet.net/mirror/gentoo/ http://91.121.124.139/gentoo-distfiles/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/gentoo/files/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--exclude-from=/etc/portage/excludes"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/gentoo/portage"
PORTDIR_OVERLAY="/usr/gentoo/overlay/sunrise /usr/gentoo/overlay/science /usr/gentoo/overlay/desktop-effects /usr/gentoo/overlay/bircoph /usr/gentoo/overlay/sabayon /usr/gentoo/overlay/hasufell /usr/gentoo/portage /usr/gentoo/overlay/various /usr/gentoo/overlay/sam"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="7zip X a52 aac acl acpi aio alsa amd64 amr apache2 audiofile audit bash-completion berkdb bidi bs2b bzip2 cairo caps cdda cddb cdparanoia cdr cg cli cracklib crypt cscope css cue cups curl cxx dbus dga dia directfb dri dts dvd dvdr dvdread egl encode exif faac fam fat fbcon ffmpeg fftw fits flac fluidsynth fontconfig fortran fuse gallium gcrypt gd gdbm gif gimp glade gmp gnutls gphoto2 gpm graphviz gsm gtk gtk2 iconv icu id3 id3tag idn imlib introspection iodbc ipv6 jack jbig joystick jpeg jpeg2k kerberos ladspa lapack lcms ldap libass libcaca libkms libsamplerate lm_sensors lzma lzo mad midi mikmod mmx mmxext mng modules mozilla mp3 mp4 mpeg mpi mtp mudflap multilib ncurses nls nptl ntfs odbc offensive ogg openal opencl openexr opengl openmp openvg oss pam pango pcap pch pcre pdf png pnm portaudio postscript pvr qt3support rar raw readline rle romio rtc rtmp rtsp samba sasl sdl session smime smp sndfile sockets soundtouch spell srt sse sse2 sse3 sse4_1 ssl ssse3 startup-notification svg syslog tcpd tga theora threads tiff truetype twolame unicode urandom usb v4l v4l2 vaapi vdpau vim-syntax vorbis vpx wavpack wma wmf x264 xattr xcb xcomposite xdb xface xft xinetd xml xmp xosd xpm xrandr xv xvid xvmc zip zlib zsh-completion" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_core authn_dbd authn_dbm authn_default authn_file authz_core authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info lbmethod_byrequests lbmethod_bytraffic lbmethod_bybusyness lbmethod_heartbeat log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif sosocache_shmbc speling status unique_id unixd userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DRACUT_MODULES="syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev joystick keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="pdfimport presenter-console presenter-minimizer" LINGUAS="fr fr_FR en vi" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-4" PYTHON_SINGLE_TARGET="python3_2" PYTHON_TARGETS="python3_3 python3_2 python2_7" RUBY_TARGETS="ruby19" USERLAND="GNU" VIDEO_CARDS="nouveau nvidia fbdev vesa none v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, USE_PYTHON

P.S.: Testing just gave me a little headache, when I tried to downgrade the glibc. I didn't know about the eblits files under in the ebuild directory. (I need elder glibc version has a boost dependencie, and always prefer to keep such important ports stables)
Comment 4 Sergey Popov gentoo-dev 2013-07-29 11:27:01 UTC
(In reply to Samuel BAUER from comment #3)
> Created attachment 353606 [details]
> build.log
> 
> The build worked fine for me, maybe the glibc patchset has been updated
> since the bug was opened. Maybe something in my test is missing, just try to
> notice it to me if you see something wrong.

It is not glibc issue. If you redefine default linker(by making 'cp ld.gold ld' in 
/usr/x86_64-pc-linux-gnu/binutils-bin/2.23.1/) you will got exactly the same error, because of gold linker is more strict and does not support underlinking[1]. My version of installed binutils - 2.23.1, your version can be different.

[1] - https://blog.flameeyes.eu/2010/11/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing
Comment 5 Samuel Bauer 2013-08-14 12:52:50 UTC
Created attachment 355988 [details]
gtkdiskfree-2.0.1-r1.ebuild

I added LIBS="-lm" to the econf call. I assume it will explicitely link to the missing lib. Hope it's good when linking with gold (I changed it in the build system but still didn't pushed changes).
Leeds me to one question: whether with --as-needed or --no-copy-dt-needed-entries as cited in #comment3 , gcc ld still links everything fine, why so ?

I also removed the -g option from the makefile (an error in the build system, I'll fix it later, and push).

Also changed from !gtk3? ( x11-libs/gtk+:3 ) to !gtk3? ( x11-libs/gtk+:2 ), the ebuild is more consistent so.
Comment 6 Sergey Popov gentoo-dev 2013-08-14 13:00:00 UTC
(In reply to Samuel BAUER from comment #5)
> Also changed from !gtk3? ( x11-libs/gtk+:3 ) to !gtk3? ( x11-libs/gtk+:2 ),
> the ebuild is more consistent so.

Maybe introducing new USE-flag gtk and setting something like:

REQUIRED_USE="^^ ( gtk gtk3 )"

will be even more consistent, no?

And src_configure can be simplified, i will post my suggestion later...
Comment 7 Sergey Popov gentoo-dev 2013-08-19 12:01:44 UTC
(In reply to Sergey Popov from comment #6)
> Maybe introducing new USE-flag gtk and setting something like:
> 
> REQUIRED_USE="^^ ( gtk gtk3 )"
> 
> will be even more consistent, no?


It seems that i was wrong, look at https://wiki.gentoo.org/wiki/Gnome_Team_Policies#gtk3. So, we should leave support for only one of GTK+ major versions...
Comment 8 Sergey Popov gentoo-dev 2013-08-19 16:39:49 UTC
+  19 Aug 2013; Sergey Popov <pinkbyte@gentoo.org> +gtkdiskfree-2.0.1-r1.ebuild,
+  +files/gtkdiskfree-2.0.1-desktop-file.patch:
+  Revision bump: EAPI 5, port to autotools-utils eclass, fix desktop file, fix
+  underlinking wrt bug #463578, drop GTK2 support
Comment 9 Samuel Bauer 2013-08-19 23:09:51 UTC
In reply to #comment 8

I accepted to proxy-maintain gtkdiskfree only with gtk2 support, when I ported gtkdiskfree to gtk3 (see #410757)
gtk flag is so often used instead of gnome one, it seems really confusing, but not forbidden.
Some apps are working as a charm when compiled with gtk2, but really buggy if comipled with gtk3, and dot being able to compile apps with the toolkit one dare to, is the new gentoo policy. 
EXTRA_ECONF="--with-gtk2" is just a quick workaround (extra dependencies needed only with gtk3, ...).
On the other hand maintaining for both gtk version becomes harder, but it could just be available but unsupported.

About desktop file, can you mail me your patch, I also tried to fix it (changing file encoding), desktop-file-validate doesn't insult more, but I'm not sure russian translation are still good.
Comment 10 Sergey Popov gentoo-dev 2013-08-20 08:28:56 UTC
(In reply to Samuel BAUER from comment #9)
> In reply to #comment 8
> 
> I accepted to proxy-maintain gtkdiskfree only with gtk2 support, when I
> ported gtkdiskfree to gtk3 (see #410757)
> gtk flag is so often used instead of gnome one, it seems really confusing,
> but not forbidden.
> Some apps are working as a charm when compiled with gtk2, but really buggy
> if comipled with gtk3, and dot being able to compile apps with the toolkit
> one dare to, is the new gentoo policy. 
> EXTRA_ECONF="--with-gtk2" is just a quick workaround (extra dependencies
> needed only with gtk3, ...).
> On the other hand maintaining for both gtk version becomes harder, but it
> could just be available but unsupported.

Recent discussion in gentoo-dev blames for such confusions. I have tested GTK+-3 versions - it does seem fail or buggy for me. I am not against choice for users, but if it becomes burden for team - it is not good(even if Gnome guys do not maintain this package - they are appeal court in possible hard situations, and i do not want to violate their policies for no reason)

> About desktop file, can you mail me your patch, I also tried to fix it
> (changing file encoding), desktop-file-validate doesn't insult more, but I'm
> not sure russian translation are still good.

Feel free to pickup it here - http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-admin/gtkdiskfree/files/gtkdiskfree-2.0.1-desktop-file.patch?revision=1.1
Comment 11 Samuel Bauer 2013-08-20 12:47:57 UTC
Thanks for the patch link. Diff with mine is just that I used to remove the MultipleArgs entry instead of changing it to X-MultipleArgs, there was no matter with encoding.

I understand your point of view. Even it's good way to track bug for me to be ebuild maintainer, just remove me of the maintainer list in the metadata.xml file if no gtk2 support, maybe also ask Michael Weber if he still want to proxy-commit with no proxy-maintainer.
Comment 12 Sergey Popov gentoo-dev 2013-08-20 13:33:59 UTC
(In reply to Samuel BAUER from comment #11)
> I understand your point of view. Even it's good way to track bug for me to
> be ebuild maintainer, just remove me of the maintainer list in the
> metadata.xml file if no gtk2 support, maybe also ask Michael Weber if he
> still want to proxy-commit with no proxy-maintainer.

I have requested some clarifications about this in maillist. Maybe we could reintroduce GTK2 support in some other way...
Comment 13 Samuel Bauer 2013-08-20 20:02:35 UTC
In reply to #comment 12

Did you post to gentoo-devhelp maillist, I would like to register to follow the  thread it is discussed in. It can give me a larger view of the ideas other people submit.

As I'm not quite sure which list it is in, I prefer to ask before registering.
Comment 14 Sergey Popov gentoo-dev 2013-08-21 07:03:10 UTC
(In reply to Samuel BAUER from comment #13)
> In reply to #comment 12
> 
> Did you post to gentoo-devhelp maillist, I would like to register to follow
> the  thread it is discussed in. It can give me a larger view of the ideas
> other people submit.
> 
> As I'm not quite sure which list it is in, I prefer to ask before
> registering.

i have asked in gentoo-dev maillist, you can follow thread here - http://comments.gmane.org/gmane.linux.gentoo.devel/87600, subscribe instructions - http://www.gentoo.org/main/en/lists.xml

As you can see - there is no strong opinion about that policy, so you probably should say what you think as maintainer.