Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 461682 - multilib.eclass: multilib_toolchain_setup does not preserve unset variables as unset
Summary: multilib.eclass: multilib_toolchain_setup does not preserve unset variables a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-14 00:14 UTC by Julian Ospald
Modified: 2013-04-22 01:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
libdbusmenu-0.6.2-r1.ebuild (libdbusmenu-0.6.2-r1.ebuild,1.71 KB, text/plain)
2013-03-14 00:14 UTC, Julian Ospald 		Details
multilib.eclass.diff (multilib.eclass.diff,858 bytes, patch)
2013-03-14 00:16 UTC, Julian Ospald 		Details | Diff
Alternative patch: using 'unset' state (multilib-eclass-v2.patch,966 bytes, patch)
2013-03-14 07:58 UTC, Michał Górny 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-03-14 00:14:18 UTC 
Created attachment 341970 [details]
libdbusmenu-0.6.2-r1.ebuild

It seems some packages have different behavior when PKG_CONFIG_LIBDIR is unset vs empty, thus resulting in failure for multilib aware ebuilds during the _default_ ABI configure run (not for the non-default one).

The variable preserve logic in multilib_toolchain_setup function will export all previously unset variables as empty variables which triggers this failure.

An example ebuild is attached which makes use of "/usr/share/pkgconfig/gnome-doc-utils.pc" from app-text/gnome-doc-utils, but the default ABI will be unable to find it.
Comment 1 Julian Ospald 2013-03-14 00:16:15 UTC 
Created attachment 341972 [details, diff]
multilib.eclass.diff

I think this is a possible fix, please review.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-14 07:58:24 UTC 
Created attachment 341998 [details, diff]
Alternative patch: using 'unset' state

I'd honestly see it a bit different -- instead of using magic values, we can just 'keep' the unset variables unset ;).
Comment 3 Julian Ospald 2013-04-19 21:51:43 UTC 
any news here?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-04-20 05:04:06 UTC 
(In reply to comment #3)
> any news here?

I'll submit it to the ml.