Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 46070 - repoman should ignore files that cvs ignores
Summary: repoman should ignore files that cvs ignores
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-28 21:28 UTC by Robin Johnson
Modified: 2004-08-16 20:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Makes repoman ignore the hardcoded stuff from cvs as per url, needs more work still. (repoman-ignorecvsfiles.patch,667 bytes, patch)
2004-03-28 21:29 UTC, Robin Johnson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-03-28 21:28:46 UTC
repoman should ignore files that cvs ignores
see http://www.cvshome.org/docs/manual/cvs-1.12.6/cvs_18.html#SEC177
for the list of files ignored.

trivial patch attached that does some of the ignore work.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-03-28 21:29:30 UTC
Created attachment 28255 [details, diff]
Makes repoman ignore the hardcoded stuff from cvs as per url, needs more work still.
Comment 2 Brian Harring (RETIRED) gentoo-dev 2004-08-13 14:56:34 UTC
see bug #21841 , not much for it, although I specifically disliked ignoring *~; if CVS is flat out ignoring these files always, I could see adding this I guess.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-08-13 15:02:02 UTC
i'm strongly in favour of repoman ignoring the files that CVS ignores.
It makes development much easier. And *~ backups have saved me on a number of times.

Could we please have this feature?
Comment 4 Brian Harring (RETIRED) gentoo-dev 2004-08-13 15:25:11 UTC
Robin, the modifications look fine; guessing you've been using this for a while?
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-08-13 15:48:03 UTC
yup, it's been a few months now.

there is one further thing that it should do:
check for existence of .cvsignore and use extensions from there instead if exists. (checks should be recursive up to the root of the checkout.)

However we don't use .cvsignore anywhere in the tree presently, so it can just something for later on.
Comment 6 Brian Harring (RETIRED) gentoo-dev 2004-08-13 15:54:27 UTC
"there is one further thing that it should do:
check for existence of .cvsignore and use extensions from there instead if exists. (checks should be recursive up to the root of the checkout.)"

Makes sense I spose, although I'd think it would be of limited use; if devs request it (and somebody offers up a patch :) it's viable.
Meanwhile, commiting your patch.
Comment 7 Nicholas Jones (RETIRED) gentoo-dev 2004-08-15 14:56:32 UTC
Portage needs to understand this for manifests before it can be
considered for implementation. EXCESS files in Manifest is a failure
for a manifest check.

I have removed this (partially broken) patch for the moment.
|*~| is not valid. Many of the elements are wrong in that list.
R.E.s are not the same a globs.
Comment 8 Brian Harring (RETIRED) gentoo-dev 2004-08-16 20:56:24 UTC
A fixed up version went out in pre20 that 1) rewrote the glob match into a regex match, 2) correctly exempted files from digest(gen|check) to keep the Manifest clean from excess files.