Hello, net-misc/htun-0.9.5 compiles and works fine on ~amd64.
Some issues detected: 1. Invalid Gentoo Copyright on line: 1 Should be: # Copyright 1999-2013 Gentoo Foundation 2. Are you using EAPI=0? 3. ebuild calls gcc directly, and uses -g flag (Added blocker to this bug) gcc -I../include -I. -g -D_REENTRANT -c y.tab.c 4. Missing || die at lines 21 and 30 5. The package does not compile in my box: gcc -I../include -I. -g -D_REENTRANT -c y.tab.c In file included from gram.y:31:0: ../include/common.h:139:15: warning: built-in function 'log' declared as non-function [enabled by default] gram.y:305:6: warning: conflicting types for 'die_error' [enabled by default] gram.y:205:21: note: previous implicit declaration of 'die_error' was here gram.y:322:6: warning: conflicting types for 'yyerror' [enabled by default] y.tab.c:2035:7: note: previous implicit declaration of 'yyerror' was here gram.y:327:6: warning: conflicting types for 'yy_error' [enabled by default] gram.y:199:21: note: previous implicit declaration of 'yy_error' was here gram.y:332:13: warning: conflicting types for 'set_ip' [enabled by default] gram.y:332:13: error: static declaration of 'set_ip' follows non-static declaration gram.y:154:17: note: previous implicit declaration of 'set_ip' was here gram.y:346:12: error: static declaration of 'get_answer' follows non-static declaration gram.y:122:56: note: previous implicit declaration of 'get_answer' was here gram.y:356:15: error: static declaration of 'set_base64_user_pass' follows non-static declaration gram.y:212:47: note: previous implicit declaration of 'set_base64_user_pass' was here make: *** [y.tab.o] Error 1 emake failed
The ebuild really needs some work. The package installs fine for me though. Also, there seems to be a 0.9.6 version out there.
I've updated the package: * fixes copyright * updated ebuild (eapi=5) * add missing die's * fixes calling gcc directly * fixes dosen't respect users cflags/ldflags * version bump to 0.9.6 * added ~amd64 keyword * updated homepage (original seems to be offline, i took the hp from archs package) * updated glibc patch (a few things got fixed with the new version) The package builds fine for me too (on amd64). Please take a look at the ebuild. Hope it's mostly correct :)
Created attachment 341340 [details] htun-0.9.6.ebuild ebuild for the latest version
Created attachment 341342 [details, diff] htun-0.9.6-glibc.patch updated glibc patch
Created attachment 341344 [details, diff] htun-0.9.6-makefile.patch makefile patch
(In reply to comment #3) > I've updated the package: > * fixes copyright > * updated ebuild (eapi=5) > * add missing die's > * fixes calling gcc directly > * fixes dosen't respect users cflags/ldflags > * version bump to 0.9.6 > * added ~amd64 keyword > * updated homepage (original seems to be offline, i took the hp from archs > package) > * updated glibc patch (a few things got fixed with the new version) > > The package builds fine for me too (on amd64). Please take a look at the > ebuild. Hope it's mostly correct :) Thanks, works fine here on both ~x86 and ~amd64. Though repoman is not happy with patching in src_unpack(), this is fixed below.
Created attachment 341428 [details] htun-0.9.6.ebuild Updated ebuild with epatch commands placed into src_prepare() as EAPI>=2 requires.
Nice =) Do you get these QA issues? * QA Notice: Package triggers severe warnings which indicate that it * may exhibit random runtime failures. * queue.c:155:5: warning: null argument where non-null required (argument 1) [-Wnonnull] * queue.c:223:5: warning: null argument where non-null required (argument 1) [-Wnonnull] * queue.c:263:5: warning: null argument where non-null required (argument 1) [-Wnonnull]
Yes, I got them. At the first glance at the code, non-null requirements are outdated.
+ 12 Mar 2013; Sergey Popov <pinkbyte@gentoo.org> +htun-0.9.6.ebuild, + +files/htun-0.9.6-glibc.patch, +files/htun-0.9.6-makefile.patch, + +files/README.gentoo: + Version bump, wrt bug #460656. EAPI 5, add ~amd64 keyword, add epatch_user, + use readme.gentoo eclass instead of simple message in pkg_postinst, respect + CFLAGS, LDFLAGS and compiler. Thanks to Michael Mair-Keimberger and Andrew + Savchenko for ebuild improvements
