Created attachment 341104 [details]
murmur-1.2.4 fails to (re-)build:
Server.cpp: In member function ‘void Server::udpActivated(int)’:
Server.cpp:553:21: error: ‘MAX’ was not declared in this scope
compilation terminated due to -Wfatal-errors.
make: *** [Server.o] Error 1
make: Leaving directory `/var/tmp/portage/media-sound/murmur-1.2.4_beta1-r1/work/mumble-1.2.4~beta1/src/murmur'
Created attachment 341106 [details]
Created attachment 341108 [details, diff]
This patch will avoid the issue by providing a MAX macro unless one has already been defined. This avoids the trouble of identifying where the macro might have come from in previous builds or on upstream build systems.
As murmur uses epatch_user, you can simply drop this file into a (newly created) directory called /etc/portage/patches/media-sound/murmur and emerge mumble. This is a quick solution until the issue has been fixed in the main portage tree.
Would be nice to know if murmur-1.2.4_rc1 is affected as well.
(In reply to comment #3)
> Would be nice to know if murmur-1.2.4_rc1 is affected as well.
seems to work on my amd64-server
(In reply to comment #4)
> (In reply to comment #3)
> > Would be nice to know if murmur-1.2.4_rc1 is affected as well.
> seems to work on my amd64-server
erm sorry, using "1.2.4_beta1-r1" since the _rc1 isn't in tree yet. seems to be related to installed version of protobuf
The latest available snapshot mumble-1.2.4~rc1-8-gb115a29.tar.gz seems to be affected as well. Martin would you please report this upstream to get your fix committed so we can add it to the ebuild as well? Thanks.
(In reply to comment #6)
> Martin would you please report this upstream […]
Reported at https://github.com/mumble-voip/mumble/pull/153
Fix committed upstream as https://github.com/mumble-voip/mumble/commit/5aec9c6403d6bc65f957ee1648e6848f2287f670
(In reply to Martin von Gagern from comment #8)
> Fix committed upstream as
Thanks for taking care of this! Version 1.2.4 including the fix is now in CVS.