460020 – dev-vcs/mercurial: conversion to distutils-r1

Bug 460020 - dev-vcs/mercurial: conversion to distutils-r1

Summary: dev-vcs/mercurial: conversion to distutils-r1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Dirkjan Ochtman (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	python-r1-tracker
	Show dependency tree

Reported:	2013-03-02 17:51 UTC by Michał Górny
Modified:	2013-03-10 10:24 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to mercurial-2.5.1.ebuild (mercurial-2.5.1.ebuild.diff,4.66 KB, patch) 2013-03-02 17:51 UTC, Michał Górny	Details \| Diff
Patch to the current ebuild (mercurial-2.5.2.ebuild.diff,840 bytes, patch) 2013-03-08 16:20 UTC, Michał Górny	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2013-03-02 17:51:27 UTC

Created attachment 340786 [details, diff]
Patch to mercurial-2.5.1.ebuild

Attaching a patch.

Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev

2013-03-03 11:44:26 UTC

Seems pretty okay. Is something like PYTHON_MODNAME="${PN} hgext" no longer needed at all? We'd sure want to install the extensions...

Comment 2 Michał Górny archtester

2013-03-03 12:31:25 UTC

(In reply to comment #1)
> Seems pretty okay. Is something like PYTHON_MODNAME="${PN} hgext" no longer
> needed at all? We'd sure want to install the extensions...

Yes, that was necessary for pkg_postinst() module compilation. Now the modules are compiled in src_install().

Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2013-03-08 13:00:49 UTC

+*mercurial-2.5.2 (08 Mar 2013)
+
+  08 Mar 2013; Lars Wendler <polynomial-c@gentoo.org> -mercurial-2.1.1.ebuild,
+  -files/mercurial-2.4-dont_grep_indefinitely.patch, -mercurial-2.5.ebuild,
+  +mercurial-2.5.2.ebuild:
+  Version bump. Removed old. Converted bumped ebuild to use distutils-r1 (bug
+  #460020).
+

Let's see if this bombs out :)

@mgorny: I had to tweak one line added by your patch a bit. Without that tweak the ebuild failed for me.

Comment 4 Michał Górny archtester

2013-03-08 16:12:27 UTC

(In reply to comment #3)
> +*mercurial-2.5.2 (08 Mar 2013)
> +
> +  08 Mar 2013; Lars Wendler <polynomial-c@gentoo.org>
> -mercurial-2.1.1.ebuild,
> +  -files/mercurial-2.4-dont_grep_indefinitely.patch, -mercurial-2.5.ebuild,
> +  +mercurial-2.5.2.ebuild:
> +  Version bump. Removed old. Converted bumped ebuild to use distutils-r1
> (bug
> +  #460020).
> +
> 
> Let's see if this bombs out :)
> 
> @mgorny: I had to tweak one line added by your patch a bit. Without that
> tweak the ebuild failed for me.

You should've told me. You probably found a bug and worked it around rather than reporting it, resulting in possibly random results depending on eselected Python...

Comment 5 Michał Górny archtester

2013-03-08 16:20:23 UTC

Created attachment 341314 [details, diff]
Patch to the current ebuild

Please 'cvs up -dP eclass' and try with this patch. With the current eclass, it should work just fine.

Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2013-03-09 08:51:12 UTC

(In reply to comment #5)
> Created attachment 341314 [details, diff] [details, diff]
> Patch to the current ebuild
> 
> Please 'cvs up -dP eclass' and try with this patch. With the current eclass,
> it should work just fine.

Indeed. I reverted my tweak so the ebuild now has your patch from this bug and works. Thank you :)

Comment 7 Michał Górny archtester

2013-03-09 12:56:22 UTC

Well, I wanted you to commit the whole patch but committed the remaining part myself ;). Now it should all be fixed and clean.

Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2013-03-10 10:24:34 UTC

(In reply to comment #7)
> Well, I wanted you to commit the whole patch but committed the remaining
> part myself ;). Now it should all be fixed and clean.

Sorry, I was in a hurry and didn't see your new patch.