Bug 459394 – dev-util/cmake FindFreetype.cmake should be patched for multilib support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Branko Grubic 2013-02-27 02:11:40 UTC]

poppler-0.20.5 fails to build with freetype-2.4.11-r1

Reproducible: Always

Steps to Reproduce:
1. on ~amd64 (~other_arch?)
2. emerge poppler
3.
Actual Results:  
fails 

Expected Results:  
build and install

downgrading media-libs/freetype to 2.4.11 fixes the problem

[Comment 1 Branko Grubic 2013-02-27 02:12:20 UTC]

Created attachment 340246 [details]
build log

[Comment 2 iGentoo 2013-02-27 06:25:12 UTC]

Created attachment 340270 [details, diff]
workaround patch

[Comment 3 iGentoo 2013-02-27 11:36:42 UTC]

Created attachment 340300 [details, diff]
workaround patch

[Comment 4 iGentoo 2013-02-27 12:09:26 UTC]

Created attachment 340304 [details, diff]
poppler-0.20.5.ebuild.diff

[Comment 5 eroen 2013-03-10 17:17:43 UTC]

Created attachment 341570 [details]
app-text/poppler-0.22.1 build log

app-text/poppler-0.22.1 is also affected.

[Comment 6 Nikolaj Šujskij 2013-03-11 11:10:30 UTC]

*** Bug 461334 has been marked as a duplicate of this bug. ***

[Comment 7 eroen 2013-03-12 13:04:53 UTC]

Created attachment 341800 [details]
poppler-0.22.2 build.log

app-text/poppler-0.22.2 is also affected.

[Comment 8 eroen 2013-03-12 13:55:12 UTC]

Btw, Alphat's patch (attachment 340304 [details, diff]) still works fine.

[Comment 9 eroen 2013-03-13 17:51:04 UTC]

As expected, poppler-0.22.2 builds fine with media-libs/freetype-2.4.11-r2 , as per bug 459352 comment 9.

[Comment 10 Andreas K. Hüttel 2013-03-16 11:40:58 UTC]

Added the patch to poppler-0.22.2. Will get stable soon anyway.

[Comment 11 Maciej Mrozowski 2013-06-18 00:36:59 UTC]

I have to say I don't like this patch. Looks like FindFreetype.cmake (from cmake) should be patched for multilib support instead.

[Comment 12 Andreas K. Hüttel 2013-09-16 12:38:24 UTC]

(In reply to Maciej Mrozowski from comment #11)
> I have to say I don't like this patch. Looks like FindFreetype.cmake (from
> cmake) should be patched for multilib support instead.

OK adapting summary.

[Comment 13 Greg Turner 2014-01-21 19:05:14 UTC]

dev-utils/cmake-2.8.12.r1-r2 and up contain a patch to FindFreetype.cmake for this.  My overlay is able to build multilib poppler without the FREETYPE_DIR hack that reavertm (Maciej) objects to above.

So, I am just putting:

  # bug 495394
  CMAKE_MIN_VERSION=2.8.12.1-r2

at the top of the ebuild, before the inherit clause, and dropping the FREETYPE_DIR business.  I'd surmise that this should work for most ebuilds with similar problems.

[Comment 14 Michael Palimaka (kensington) 2014-03-16 12:05:30 UTC]

(In reply to Greg Turner from comment #13)
> dev-utils/cmake-2.8.12.r1-r2 and up contain a patch to FindFreetype.cmake
> for this.  My overlay is able to build multilib poppler without the
> FREETYPE_DIR hack that reavertm (Maciej) objects to above.
> 
> So, I am just putting:
> 
>   # bug 495394
>   CMAKE_MIN_VERSION=2.8.12.1-r2
> 
> at the top of the ebuild, before the inherit clause, and dropping the
> FREETYPE_DIR business.  I'd surmise that this should work for most ebuilds
> with similar problems.

reavertm/dilfridge: can you please confirm and remove the hack from poppler ebuild?

[Comment 15 Maciej Mrozowski 2014-05-16 21:10:44 UTC]

Let's way for stabilization of that CMake. Then we can remove workaround from poppler altogether.

[Comment 16 Johannes Huber (RETIRED) 2014-07-13 10:40:21 UTC]

Thanks all.

+  13 Jul 2014; Johannes Huber <[e-mail]> -poppler-0.26.1.ebuild,
+  poppler-0.26.2.ebuild, poppler-9999.ebuild:
+  Remove workaround on freetype, this is fixed in current stable dev-
+  util/cmake-2.8.12.2, bug #459394.