Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 458192 - dev-vcs/subversion: please review python-r1 conversion
Summary: dev-vcs/subversion: please review python-r1 conversion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Thomas Sachau
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: python-r1-tracker
  Show dependency tree
 
Reported: 2013-02-18 23:02 UTC by Michał Górny
Modified: 2013-03-03 11:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
1) initial clean up for EAPI 5 (0001-EAPI-5-cleanup.patch,4.70 KB, patch)
2013-02-18 23:02 UTC, Michał Górny
Details | Diff
2) Actual -r1 conversion (0002-Convert-to-distutils-r1.patch,8.91 KB, patch)
2013-02-18 23:02 UTC, Michał Górny
Details | Diff
2) python-r1 conversion, -r1 (0002-Convert-to-distutils-r1.patch,9.24 KB, text/plain)
2013-02-19 14:38 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-18 23:02:05 UTC
Created attachment 339312 [details, diff]
1) initial clean up for EAPI 5

Please review the distutils-r1 conversion I attach.

First patch does the initial EAPI 5 changes to avoid making the actual conversion hard to read. Second one does it.

Major changes:

- proper Python deps,

- swig hackery done a little cleaner (one sed less),

- ctype-based bindings built using distutils (and generated only once rather than three times as with python.eclass).
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-18 23:02:40 UTC
Created attachment 339314 [details, diff]
2) Actual -r1 conversion
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-19 00:05:25 UTC
Note to self: 'make check' doesn't run binding test phases. Take a look at running them.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-19 14:38:54 UTC
Created attachment 339366 [details]
2) python-r1 conversion, -r1

Changes:

- use of complete src_* phases from distutils-r1,

- Python binding tests are run as well.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-03-03 11:02:29 UTC
Committed a few days ago.