457634 – media-libs/imlib2-1.4.5 with media-libs/giflib-5.0.x - pass NULL a second argument to DGifOpenFileHandle

Bug 457634 - media-libs/imlib2-1.4.5 with media-libs/giflib-5.0.x - pass NULL a second argument to DGifOpenFileHandle

Summary: media-libs/imlib2-1.4.5 with media-libs/giflib-5.0.x - pass NULL a second arg...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Graphics Project

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	giflib-5
	Show dependency tree

Reported:	2013-02-15 00:21 UTC by Andrew John Hughes
Modified:	2014-01-18 20:19 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Pass NULL as second argument if on giflib5. (imlib-1.4.5.patch,364 bytes, patch) 2013-02-15 00:22 UTC, Andrew John Hughes	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew John Hughes 2013-02-15 00:21:14 UTC

DGifOpenFileHandle takes an optional extra parameter (a pointer to an int for an error code) on giflib 5, so the build fails.  The attached patch fixes the issue.

Reproducible: Always

Comment 1 Andrew John Hughes 2013-02-15 00:22:18 UTC

Created attachment 338922 [details, diff]
Pass NULL as second argument if on giflib5.

Comment 2 Emil Medve 2014-01-11 07:02:00 UTC

Confirm both build issue and patch effectiveness to complete the build for imlib2-1.4.6

Comment 3 SpanKY gentoo-dev

2014-01-18 20:19:22 UTC

should be all set now in the tree; thanks for the report!

Commit message: Add fix from upstream for giflib-5
http://sources.gentoo.org/media-libs/imlib2/files/imlib2-1.4.5-giflib-5.patch?rev=1.1
http://sources.gentoo.org/media-libs/imlib2/imlib2-1.4.5-r1.ebuild?r1=1.1&r2=1.2
http://sources.gentoo.org/media-libs/imlib2/imlib2-1.4.6-r1.ebuild?r1=1.1&r2=1.2