https://github.com/ymattw/cdiff Reproducible: Always
ebuild at https://github.com/yaccz/gentoo-overlay/blob/master/dev-python/cdiff/cdiff-0.1.ebuild
The ebuild is good. ~/cvsPortage/gentoo-x86/dev-python/cdiff $ ebuild cdiff-0.1.ebuild clean test ---------------------------------------------- running build_scripts creating /var/tmp/portage/portage/dev-python/cdiff-0.1/work/cdiff-0.1-python2_7/scripts copying and adjusting cdiff -> /var/tmp/portage/portage/dev-python/cdiff-0.1/work/cdiff-0.1-python2_7/scripts changing mode of /var/tmp/portage/portage/dev-python/cdiff-0.1/work/cdiff-0.1-python2_7/scripts/cdiff from 644 to$ >>> Source compiled. ^[[32;01m*^[[0m python3.1: running distutils-r1_run_phase python_test src/cdiff.py tests/git.diff src/cdiff.py tests/svn.diff src/cdiff.py tests/crlf.diff src/cdiff.py tests/strange.diff Index: README.md =================================================================== --- README.md (revision 41) +++ README.md (working copy) @@ -3,7 +3,6 @@ ## About and so forth. You need to make this happen. Happily the tests all pass all pythons, no troubleshooting required. You might also check in with python team lead to get an ok to add this little package. Given it's little increases its chances.
I don't think this belongs in dev-python, and I'm not sure I'd task the python team with maintaining it by default.
(In reply to comment #3) > I don't think this belongs in dev-python, and I'm not sure I'd task the > python team with maintaining it by default. Why wouldn't it? (In reply to comment #2) > Happily the tests all pass all pythons, no troubleshooting required. The tests require manual inspection of the output and are not included in the ebuild.
Because dev-python generally contains packages target specifically at python developers. This package builds on Python, but it doesn't specifically target python developers; it makes more sense in dev-util, or perpaps dev-vcs.
(In reply to comment #5) > Because dev-python generally contains packages target specifically at python > developers. This package builds on Python, but it doesn't specifically > target python developers; it makes more sense in dev-util, or perpaps > dev-vcs. Allright, that sounds reasonable. I don't really care what category the package is in.
Tests requirements here are an exception to the rule. Why do you keep doing this to me Jan?? Yes the tests are diff files and don't register a pass or fail, so in this it makes them tests, not a test suite. In this sense it also fits the suggestion of not adding to dev-python. Take your pick of categories, I can add it if you still wish unless you get someone else to do so.
Upstream has made some more releases and I plan to improve the tests when i get to it. (In reply to comment #7) > I can add it if you still wish unless you get > someone else to do so. I will push this ebuild through sunrise
fine, remember to close this once in sunrise
Ian: Sunrise policy is to leave the bug open until a developer moves it to the gentoo-x86 tree. Do not tell people to close bugs after committing ebuilds in sunrise.
> I will push this ebuild through sunrise There's no need to do that. Since I like this package and will be using it, I am stepping up to maintain this package and have added it to Portage. +*cdiff-0.3 (09 Feb 2013) + + 09 Feb 2013; Tom Wijsman <TomWij@gentoo.org> +cdiff-0.3.ebuild, +metadata.xml: + New package for cdiff. Contributed by Jan Matějka. Fixed bug #455624.
As a side note, I have chosen for dev-util since most other diff tools can be found there. Please wait some hours for this addition to propagate to your local mirror. Thank you for your contribution.
