Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 45295 - gnome-panel-2.5.93 fails on automake without gtk-doc package
Summary: gnome-panel-2.5.93 fails on automake without gtk-doc package
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 45451 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-03-21 10:39 UTC by Matthew Schick
Modified: 2004-04-03 03:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (gnome-panel-2.5.93_gtk-doc.patch,463 bytes, patch)
2004-03-21 10:41 UTC, Matthew Schick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Schick 2004-03-21 10:39:28 UTC
Subject pretty much says it all... Patch attached, error message below:

 USE="doc" ebuild gnome-panel-2.5.93.ebuild unpack
>>> md5 src_uri ;-) gnome-panel-2.5.93.tar.bz2
>>> Unpacking source...
>>> Unpacking gnome-panel-2.5.93.tar.bz2 to /var/tmp/portage/gnome-panel-2.5.93/work
configure.in:26: warning: AC_ARG_PROGRAM invoked multiple times
gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
gtk-doc.make:44: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
gtk-doc.make:135: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
 
!!! ERROR: gnome-base/gnome-panel-2.5.93 failed.
!!! Function src_unpack, Line 51, Exitcode 1
!!! (no error message)


Reproducible: Always
Steps to Reproduce:
Comment 1 Matthew Schick 2004-03-21 10:41:25 UTC
Created attachment 27743 [details, diff]
ebuild patch

This patch just adds a test and optional sed line to the ebuild...
Comment 2 foser (RETIRED) gentoo-dev 2004-03-21 11:04:33 UTC
That would work for now, but the real solution would be to fix the makefile script to not load the gconf defaults. Maybe you could patch that up ?

blocker ? -> easy workaround is present
Comment 3 Matthew Schick 2004-03-21 12:03:42 UTC
Why not just do the gconf sed on the Makefile after configure is done?  Saves time (no aclocal/automake needed) on the compile, and doesn't require this hack either...

I set to blocker since it keeps anyone from emerging that doesn't have doc in their USE flags, or gtk-doc emerged.  Counts as blockage in my book....
Comment 4 foser (RETIRED) gentoo-dev 2004-03-21 12:51:13 UTC
true, the hack will suffice for now.

But what i'd like to see is a full fix...

oh and why we do the sed before is that in general we consider it a bad habit to sed in generated files (patching should happen in _unpack, configure in _compile)
Comment 5 Matthew Schick 2004-03-21 12:58:18 UTC
I understand the reasoning behind sed/patches in src_unpack, but it just seems that in this case it would make more sense in src_compile...

I can look into a full fix, but no promises...  Got a lot on my plate atm..
Comment 6 foser (RETIRED) gentoo-dev 2004-03-22 15:33:44 UTC
ok for the time being i moved the sed to src_configure in 2.6.0, but i'd like to see a real fix here someday.

Please test
Comment 7 foser (RETIRED) gentoo-dev 2004-03-23 03:18:27 UTC
*** Bug 45451 has been marked as a duplicate of this bug. ***
Comment 8 foser (RETIRED) gentoo-dev 2004-04-03 03:16:48 UTC
i'm going to assume it works, still waiting for the clean patch though.