after installing giflib-5.0.x, ming can no longer locate the lib checking for PrintGifError in -lgif... no checking for DGifOpen in -lungif... no checking for PrintGifError in -lungif... no checking gif_lib.h usability... yes checking gif_lib.h presence... yes checking for gif_lib.h... yes
Created attachment 338944 [details, diff] Patch to fix use of giflib5 at both configure and build time
The attached patch fixes the problem. configure was looking for PrintGifError which no longer exists. Switching to DGifOpen (as the ungif test uses) fixes this and presents a number of build errors which were easily fixed by using the new open API calls.
# ldd /usr/lib/libming.so linux-vdso.so.1 (0x00007fff82fff000) libpng15.so.15 => /usr/lib64/libpng15.so.15 (0x00007f8521c21000) libgif.so.6 => /usr/lib64/libgif.so.6 (0x00007f8521a17000) libm.so.6 => /lib64/libm.so.6 (0x00007f8521719000) libfreetype.so.6 => /usr/lib64/libfreetype.so.6 (0x00007f852145f000) libz.so.1 => /lib64/libz.so.1 (0x00007f8521249000) libc.so.6 => /lib64/libc.so.6 (0x00007f8520e94000) libbz2.so.1 => /lib64/libbz2.so.1 (0x00007f8520c84000) /lib64/ld-linux-x86-64.so.2 (0x00007f8522103000)
https://github.com/libming/libming/pull/43
Created attachment 389310 [details, diff] ming-0.4.5-Fix-compilation-with-giflib-5.patch
As this is maintainer-needed, you can of course go ahead and finally fix it in the tree. Thanks a lot for the patch :)
This fix is a pre-requisite for the one in 538872. Why has the dependency been removed?
Anyway, full patch for both GifLib 5.0 and 5.1 submitted upstream: https://github.com/libming/libming/pull/47
*** Bug 538872 has been marked as a duplicate of this bug. ***
(In reply to Andrew John Hughes from comment #10) > Anyway, full patch for both GifLib 5.0 and 5.1 submitted upstream: > > https://github.com/libming/libming/pull/47 Merged: https://github.com/libming/libming/commit/e25e329009f870c024099db5ff4bd9678c212ff2
media-libs/giflib-0.5.1 version bump 2016-01-08 c3f8638 in portage triggers media-libs/ming-0.4.5 preserved-rebuild, which fails, build.log attached. Upstream ming-0.4.6 and ming-0.4.7 releases should support newer giflib, can we get those imported? http://libming.org/Releases
Created attachment 422574 [details] emerge --info
Created attachment 422576 [details] build.log
The GIT version builds fine here - see the attached ebuild
Created attachment 422692 [details] ming-9999.ebuild
(In reply to Jeff Kowalczyk from comment #13) > media-libs/giflib-0.5.1 version bump 2016-01-08 c3f8638 in portage triggers > media-libs/ming-0.4.5 preserved-rebuild, which fails, build.log attached. I see the same. Took me a while to find this bug report here, since its subject doesn't mention GifErrorString which is where the build actually failed for me: checking for GifErrorString in -lgif... yes checking for PrintGifError in -lgif... no checking for DGifOpen in -lungif... no […] /var/tmp/portage/media-libs/ming-0.4.5/work/ming-0.4.5/src/libming.h:85:44: error: too few arguments to function ‘GifErrorString’ fprintf(stderr, "\nGIF-LIB error: %s.\n", GifErrorString()); ^
Created attachment 423908 [details, diff] ming-0.4.5-giflib-5.0-and-5.1-compat.patch Official patch from upstream. Please test in overlays if you want a stable version and not the live master branch.
Oh, the patch includes the fixes already in this patch that's in the official tree: ming-0.4.5-gif-error.patch This is why the patch is labeled 5.0 and 5.1 compat.
Created attachment 423910 [details, diff] ming-0.4.5-giflib-5-compat.patch Whoops. Wrong version of the patch. Sorry. Here's the one actually for ming 0.4.5.
*** Bug 551410 has been marked as a duplicate of this bug. ***
Fixed in 0.4.7.
