Bug 450158 – games-action/openastromenace-1.3.1 - patch with several enhancements

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mikhail Kurinnoi 2013-01-04 10:58:15 UTC]

Created attachment 334392 [details, diff]
openastromence game patch

I just uploaded to sf.net patch for 4 bugs in openastromenace game. Please note, this patch also include fix for overflow bug in VFS code that Michael found and mail me (openastromenace-1.3.1-overflow.patch).

Patch description:

1 Fixed minor bug with keyboard control over active menu elements during setup game control keys.
2 Fixed Textures Quality option work during game data loading with new planetary and normal map textures.
3 Fixed bug that might corrupt overall game rendering (big blinking triangles over scene).
4 Fixed overflow in VFS code.

[Comment 1 Mikhail Kurinnoi 2013-01-04 11:00:07 UTC]

Ahh... forgot to mentioned, this is openastromenace version 1.3.1 patch.

[Comment 2 Sergey Popov 2013-01-04 11:10:37 UTC]

Does this patch completely accepted by upstream for inclusion in next version?

[Comment 3 Mikhail Kurinnoi 2013-01-04 11:27:51 UTC]

All part of this patch already in upstream, and will be in next version for sure. I just decided to provide patch for already fixed bugs and support game code version 1.3.1 in this way, till next version release.

[Comment 4 Sergey Popov 2013-01-04 11:55:59 UTC]

Can your provide splitted patches? Cause i am not sure about 1)-3) but 4) should be included, cause it's security related issue.

@Games team, your opinion?

[Comment 5 Mikhail Kurinnoi 2013-01-04 12:07:50 UTC]

Created attachment 334400 [details, diff]
Patch: Fixed bug that might corrupt overall game rendering (big blinking triangles over scene).

[Comment 6 Mikhail Kurinnoi 2013-01-04 12:08:13 UTC]

Created attachment 334402 [details, diff]
Patch: Fixed minor bug with keyboard control over active menu elements during setup game control keys.

[Comment 7 Mikhail Kurinnoi 2013-01-04 12:08:36 UTC]

Created attachment 334404 [details, diff]
Patch: Fixed overflow in VFS code.

[Comment 8 Mikhail Kurinnoi 2013-01-04 12:09:03 UTC]

Created attachment 334406 [details, diff]
Patch: Fixed Textures Quality option work during game data loading with new planetary and normal map textures.

[Comment 9 Mikhail Kurinnoi 2013-01-04 12:09:59 UTC]

Sergey, Michael (mr_bones) already added patch for 4) see
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/games-action/openastromenace/files/

You can stay with this one, or use mine - this is not really big point, since strncmp are used.

[Comment 10 Sergey Popov 2013-01-12 12:20:04 UTC]

+  12 Jan 2013; Sergey Popov <[e-mail]>
+  +openastromenace-1.3.1-r1.ebuild,
+  +files/openastromenace-1.3.1-keyboard_control-fix.patch,
+  +files/openastromenace-1.3.1-rendering-blinking_triangles-fix.patch,
+  +files/openastromenace-1.3.1-textures_quality-fix.patch:
+  Revision bump: EAPI 5, add enhancement patches, wrt bug #450158. Thanks to
+  Michael Kurinnoy for providing patches