Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 448784 - app-emulation/virtualbox-modules-4.1.22 with sys-kernel/gentoo-sources-3.6.11 - Missing #include "err.h" in include/linux/iommu.h
Summary: app-emulation/virtualbox-modules-4.1.22 with sys-kernel/gentoo-sources-3.6.11...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL: https://bugzilla.kernel.org/show_bug....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-27 06:57 UTC by Bloody
Modified: 2013-10-02 14:48 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vboxpci patch to add missing header include (virtualbox-modules-4.1.22-kernel-3.6-vboxpci.patch,320 bytes, patch)
2013-01-12 01:02 UTC, Maciej Mrozowski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bloody 2012-12-27 06:57:58 UTC
As stated in this comment in a bug report for virtualbox-modules:

  https://bugs.gentoo.org/show_bug.cgi?id=433796#c21

The file "include/linux/iommu.h" in the gentoo-sources-3.6.11 package makes use of a function named ERR_PTR() which is defined in "include/linux/err.h", but the latter is not included in iommu.h, so any software that includes iommu.h would sooner or later run into the issue, so it is not a bug related to virtualbox-modules but to the include file in the kernel source.

Reproducible: Always

Steps to Reproduce:
1. Emerge virtualbox-modules-4.1.22 (amd64) with gentoo-sources-3.6.11 kernel installed & active.
2. The build fails because the function ERR_PTR() is undefined and is therefor assumed to return int instead of an expected pointer type.
3.



Fix: see this comment again:

  https://bugs.gentoo.org/show_bug.cgi?id=433796#c21

I suggest to move that bug to gentoo-sources and then add the easy fix.
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2012-12-27 09:32:34 UTC
Can you please report this upstream at https://bugzilla.kernel.org/ and leave a link to that bug here?

Gentoo Sources attempts to keep the patch set as minimal as possible; so, if something can be fixed upstream we await their response first before taking a vendor decision.
Comment 2 Bloody 2012-12-27 10:16:23 UTC
here:

  https://bugzilla.kernel.org/show_bug.cgi?id=52051
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-01-02 18:46:08 UTC
Kernel upstream has decided that VirtualBox should include both files. Hence, this bug has been assigned to the app-emulation/virtualbox-modules maintainers.
Comment 4 Maciej Mrozowski gentoo-dev 2013-01-12 01:02:10 UTC
Created attachment 335276 [details, diff]
vboxpci patch to add missing header include
Comment 5 Ben Kohler gentoo-dev 2013-10-02 14:48:31 UTC
Looks like this is fixed in all recent kernels, please reopen if there are still any problems.  See upstream commit here:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/linux/iommu.h?id=9a08d3766874835f4eba1b3d66938326c069d817