Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 448480 - app-admin/collectd should install a systemd service file
Summary: app-admin/collectd should install a systemd service file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Johan Bergström
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: systemd-consumers
  Show dependency tree
 
Reported: 2012-12-25 02:01 UTC by Markus Knetschke
Modified: 2013-01-16 07:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch (collectd.ebuild.patch,991 bytes, patch)
2012-12-25 02:01 UTC, Markus Knetschke
Details | Diff
collectd-5.2.0.ebuild (collectd-5.2.0.ebuild,12.62 KB, text/plain)
2013-01-16 06:17 UTC, Johan Bergström
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Knetschke 2012-12-25 02:01:05 UTC
Created attachment 333234 [details, diff]
Ebuild patch

The patched ebuild changes the config path in the systemd service file and install it on the correct place.
Comment 1 Johan Bergström 2013-01-16 06:17:33 UTC
Created attachment 335768 [details]
collectd-5.2.0.ebuild

Here's an updated ebuild that incorporates this change (and some other nitpicks). The merge commit can be found here: https://github.com/jbergstroem/gentoo-overlay/compare/collectd-systemd
Comment 2 Sergey Popov gentoo-dev 2013-01-16 06:57:00 UTC
+  16 Jan 2013; Sergey Popov <pinkbyte@gentoo.org> +collectd-5.2.0-r1.ebuild:
+  Revision bump: add installation of systemd service file and other little
+  fixes, wrt bug #448480. Thanks to Johan Bergström

One thing: i did not reorganize eclasses. Johan, are you sure that there are no side effects in this action?
Comment 3 Johan Bergström 2013-01-16 07:01:39 UTC
(In reply to comment #2)
> +  16 Jan 2013; Sergey Popov <pinkbyte@gentoo.org> +collectd-5.2.0-r1.ebuild:
> +  Revision bump: add installation of systemd service file and other little
> +  fixes, wrt bug #448480. Thanks to Johan Bergström
> 
> One thing: i did not reorganize eclasses. Johan, are you sure that there are
> no side effects in this action?

If there are, I didn't encounter them.

I'd love to read if there's any documentation regarding this, since I often come across people wanting me to sort variables, use flags and whatnot.
Comment 4 Sergey Popov gentoo-dev 2013-01-16 07:18:25 UTC
(In reply to comment #3)
> If there are, I didn't encounter them.

Good, then i will proceed with this

> I'd love to read if there's any documentation regarding this, since I often
> come across people wanting me to sort variables, use flags and whatnot.

Usually sorting improves readability, but exported phase functions(e.g. base_src_prepare) is used from LAST inherited eclass(of course, if you did not override src_prepare() in ebuild itself). For example, games herd policy is to alwasy include games eclass LAST. Anyway, sometimes this matters, but it seems that it is not in this case.
Comment 5 Sergey Popov gentoo-dev 2013-01-16 07:23:26 UTC
+  16 Jan 2013; Sergey Popov <pinkbyte@gentoo.org> collectd-5.2.0-r1.ebuild:
+  Sort eclasses inherit order, wrt bug #448480. Changes by Johan Bergström