Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 443860 - app-arch/cpio: please review prefix changes
Summary: app-arch/cpio: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-11-18 23:16 UTC by Jonathan Callen (RETIRED)
Modified: 2012-12-16 03:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to cpio-2.11.ebuild (cpio-2.11.ebuild.patch,1.47 KB, patch)
2012-11-18 23:16 UTC, Jonathan Callen (RETIRED)
Details | Diff
Patch to build on non-GNU compilers (cpio-2.10-irix.patch,362 bytes, patch)
2012-11-18 23:17 UTC, Jonathan Callen (RETIRED)
Details | Diff
Patch to build on non-GNU compilers (cpio-2.10-irix.patch,415 bytes, patch)
2012-11-19 03:13 UTC, Jonathan Callen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Callen (RETIRED) gentoo-dev 2012-11-18 23:16:14 UTC
Created attachment 329928 [details, diff]
patch to cpio-2.11.ebuild

Changes:
- add prefix keywords
- introduce ${EPREFIX}, ${ED}, ${EROOT} as needed
- bump to EAPI 4
- use default() for src_install()
- Add patch to build on non-GNU compilers (from bug 275295)
Comment 1 Jonathan Callen (RETIRED) gentoo-dev 2012-11-18 23:17:04 UTC
Created attachment 329930 [details, diff]
Patch to build on non-GNU compilers
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2012-11-18 23:36:33 UTC
Comment on attachment 329930 [details, diff]
Patch to build on non-GNU compilers

>srcshelton@gmail.com: Patch for IRIX
>
>http://bugs.gentoo.org/show_bug.cgi?id=275295
>
>--- src/cpiohdr.h.dist  2009-06-24 15:41:26.983725240 +0100
>+++ src/cpiohdr.h       2009-06-24 15:41:59.753567720 +0100
>@@ -24,6 +24,8 @@
also see: https://savannah.gnu.org/patch/?7838
Comment 3 SpanKY gentoo-dev 2012-11-19 00:24:01 UTC
(In reply to comment #2)

please add that bug URL to the patch itself at the top
Comment 4 SpanKY gentoo-dev 2012-11-19 00:24:46 UTC
Comment on attachment 329928 [details, diff]
patch to cpio-2.11.ebuild

>+		--with-rmt="${EPREFIX}"/usr/sbin/rmt

how about: --with-rmt='$(sbindir)/rmt'
Comment 5 Jonathan Callen (RETIRED) gentoo-dev 2012-11-19 03:11:35 UTC
(In reply to comment #4)
> Comment on attachment 329928 [details, diff] [details, diff]
> patch to cpio-2.11.ebuild
> 
> >+		--with-rmt="${EPREFIX}"/usr/sbin/rmt
> 
> how about: --with-rmt='$(sbindir)/rmt'

That should work just as well.
Comment 6 Jonathan Callen (RETIRED) gentoo-dev 2012-11-19 03:13:10 UTC
Created attachment 329934 [details, diff]
Patch to build on non-GNU compilers

Add upstream bug URL
Comment 7 SpanKY gentoo-dev 2012-11-23 04:40:06 UTC
(In reply to comment #6)

assuming you change the ebuild as suggested, feel free to commit
Comment 8 Jonathan Callen (RETIRED) gentoo-dev 2012-11-23 06:28:10 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 329928 [details, diff] [details, diff] [details, diff]
> > patch to cpio-2.11.ebuild
> > 
> > >+		--with-rmt="${EPREFIX}"/usr/sbin/rmt
> > 
> > how about: --with-rmt='$(sbindir)/rmt'
> 
> That should work just as well.

I was wrong -- configure fails with "error: Argument to --with-rmt must be an absolute file name"
Comment 9 SpanKY gentoo-dev 2012-11-26 06:55:01 UTC
(In reply to comment #8)

hrm, i've sent the paxutils guy a patch.  but in the meantime, this patch is OK.
Comment 10 Christoph Junghans (RETIRED) gentoo-dev 2012-12-16 03:25:45 UTC
Patch added by me.