Bug 442190 – emerge-webrsync: '-o' and '-g' options should be appended to rsync

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Alexander Tsoy 2012-11-07 13:46:25 UTC]

'--owner' argument should be added to rsync. Whithout it the chown in emerge-webrsync is completely useless - all files are being transferred in PORTDIR with the root ownership anyway.

This is a regression caused by the bug 364105.

Reproducible: Always

[Comment 1 Zac Medico 2012-11-07 15:42:01 UTC]

(In reply to comment #0)
> '--owner' argument should be added to rsync. Whithout it the chown in
> emerge-webrsync is completely useless - all files are being transferred in
> PORTDIR with the root ownership anyway.

Please describe what the problem is so that we can understand what it is that your suggested fix is intended to accomplish.

> This is a regression caused by the bug 364105.

Please explain how it is a regression. The --owner option was not used prior to bug 364105, as can be seen in the associated commit:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e672b5ccbbbe38eda5c733fc799a20d92a8bdf75

[Comment 2 Alexander Tsoy 2012-11-07 16:10:55 UTC]

(In reply to comment #1)
> (In reply to comment #0)
> > '--owner' argument should be added to rsync. Whithout it the chown in
> > emerge-webrsync is completely useless - all files are being transferred in
> > PORTDIR with the root ownership anyway.
> 
> Please describe what the problem is so that we can understand what it is
> that your suggested fix is intended to accomplish.

Snippet from emerge-webrsync:


local ownership="portage:portage"
[..]
chown ${ownership} portage > /dev/null 2>&1 && \
    chown -R ${ownership} portage
cd portage
rsync ${PORTAGE_RSYNC_OPTS} ${PORTAGE_RSYNC_EXTRA_OPTS} . "${PORTDIR%%/}"
cd ..


With default PORTAGE_RSYNC_OPTS owner and group (portage:portage by default) are not preserved when files are being transferred to PORTDIR.

> 
> > This is a regression caused by the bug 364105.
> 
> Please explain how it is a regression. The --owner option was not used prior
> to bug 364105, as can be seen in the associated commit:
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;
> h=e672b5ccbbbe38eda5c733fc799a20d92a8bdf75

The -a option was used which implies -o (--owner) and -g (--group) options.

[Comment 3 Zac Medico 2012-11-07 16:51:37 UTC]

Okay, thanks for the explanation. This should fix it:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e672b5ccbbbe38eda5c733fc799a20d92a8bdf75

[Comment 4 Zac Medico 2012-11-07 16:53:22 UTC]

This is the fix:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=228a860476d7543608b469c569ec1d4e70aa7f59

[Comment 5 Zac Medico 2012-11-29 23:54:01 UTC]

This is fixed in 2.1.11.32 and 2.2.0_alpha143.