Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 441796 - app-arch/xz-utils: thread USE flag is stupid
Summary: app-arch/xz-utils: thread USE flag is stupid
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 868336
  Show dependency tree
 
Reported: 2012-11-05 00:27 UTC by Matt Turner
Modified: 2022-12-14 11:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2012-11-05 00:27:31 UTC
Bug 286203 was stupid. USE=threads doesn't do threaded compression or decompression, much to my disappointment. It makes liblzma threadsafe.

configure.ac says

AC_ARG_ENABLE([threads], AC_HELP_STRING([--disable-threads],
                [Disable threading support.
                This makes some things thread-unsafe.]),
        [], [enable_threads=yes])

This flag either needs to be renamed to threadsafe or removed and turned on always.
Comment 1 SpanKY gentoo-dev 2012-11-05 07:51:30 UTC
seems to me that existing usage falls under the preview of USE=threads, as does future usage (once threaded compress/decompress is added to the tools)
Comment 2 Matt Turner gentoo-dev 2012-11-07 06:42:02 UTC
(In reply to comment #1)
> seems to me that existing usage falls under the preview of USE=threads, as
> does future usage (once threaded compress/decompress is added to the tools)

I don't think we have any precedent for USE flags for things that are planned to be implemented.
Comment 3 Brian Harring (RETIRED) gentoo-dev 2012-11-07 06:45:30 UTC
tend to agree w/ matts; do we really have any justification in this day/age to have non-threadsafe as an option?

Aka, what's the actual hit?
Comment 4 SpanKY gentoo-dev 2012-11-08 07:36:05 UTC
i certainly like being able to disable threads for embedded systems

i'd also point out that the ebuild is IUSE=+threads, so only people turning off USE flags will run into a problem and i have no sympathy for them
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-14 11:05:35 UTC
commit 0c5a1376faafca0e8cac8d072a1ae6afb240af21
Author: David Seifert <soap@gentoo.org>
Date:   Sat Jul 17 00:10:40 2021 +0200

    app-arch/xz-utils: enable threads unconditionally

    * fedora/debian/arch all enable threads unconditionally

    Signed-off-by: David Seifert <soap@gentoo.org>