Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 440628 - app-portage/layman-2.0.0_rc3 - layman -L shows long overlay names truncated
Summary: app-portage/layman-2.0.0_rc3 - layman -L shows long overlay names truncated
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Brian Dolbec
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 375789
  Show dependency tree
 
Reported: 2012-10-31 17:25 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2012-11-19 01:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2012-10-31 17:25:46 UTC
As per bug #395035 , I requested the addition of an overlay named 'perl-experimental-snapshots'. 

However, layman renders this as :

 layman -L  | grep perl 
 * perl-experimental         [Git       ] (git://git.o.g.o/proj/perl-overlay...)
 * perl-experimental-snap... [Git       ] (git://github.com/gentoo-perl/perl...)

Which will then confuse a user as to what the truncated parts are, and have little idea what to pass to layman -a

So I suggest that either 

a: layman rejects / warns about oversized names  and there is a policy in place so oversized names are not added

or

b: layman is adjusted to *Not* truncate oversized names. 


For layout purposes, it may be useful to check if the label overflows the space, and add a line feed for the remaining data, ie:


 * perl-experimental         [Git       ] (git://git.o.g.o/proj/perl-overlay...)
 * perl-experimental-snapshots #
                             [Git       ] (git://github.com/gentoo-perl/perl...)


Though, I'm not entirely decided on the idea.
Comment 1 Brian Dolbec (RETIRED) gentoo-dev 2012-11-01 02:58:48 UTC
Yeah, as I was reading your message, I was thinking of adding a linefeed too.

That's probably what I'll do.  I also think it's a good idea to limit the length of a name too.  I'll talk it over with the infra team to see what we'll do officially.  I'll probably have an rc5 out this weekend with a couple small fixes and a new signed repositories.xml list capability.  stay tuned...

Thanks for reporting this.  :)
Comment 2 Brian Dolbec (RETIRED) gentoo-dev 2012-11-01 07:09:02 UTC
fixed in commit http://git.overlays.gentoo.org/gitweb/?p=proj/layman.git;a=commit;h=599442ca69c94f236132443ce8a5c24fa05fcdc1

available in layman-9999 now.
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2012-11-19 01:52:38 UTC
released in layman-2.0.0_rc5.