Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 43871 - Towbowl Tactics 0.5 ebuild
Summary: Towbowl Tactics 0.5 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL: http://www.towbowltactics.com/index_e...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-06 05:12 UTC by Christoph Brill (egore) (RESIGNED)
Modified: 2004-03-09 10:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
games-action/towbowl-tactics-0.5.ebuild (towbowl-tactics-0.5.ebuild,1.38 KB, text/plain)
2004-03-06 05:13 UTC, Christoph Brill (egore) (RESIGNED)
Details
games-action/towbowl-tactics-0.5.ebuild (towbowl-tactics-0.5.ebuild,1.33 KB, text/plain)
2004-03-07 13:51 UTC, Christoph Brill (egore) (RESIGNED)
Details
games-action/towbowl-tactics-0.5.ebuild (towbowl-tactics-0.5.ebuild,1.39 KB, text/plain)
2004-03-08 00:10 UTC, Christoph Brill (egore) (RESIGNED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Brill (egore) (RESIGNED) 2004-03-06 05:12:23 UTC
Towbowl Tactics is a Games Workshop Bloodbowl Clone. It was written in french, but version 0.5 supports english (ebuild fixes this).

Reproducible: Always
Steps to Reproduce:
Comment 1 Christoph Brill (egore) (RESIGNED) 2004-03-06 05:13:21 UTC
Created attachment 26937 [details]
games-action/towbowl-tactics-0.5.ebuild

Towbowl tactics ebuild
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2004-03-06 16:03:06 UTC
Comments on the ebuild:

use sed in src_unpack, not in src_compile when possible
use sed -i
read up on what DEPEND and RDEPEND actually are used for, you have them mixed up.
apps aren't allowed to write to things in /usr.  state files need to go in /var
don't add all the arches to KEYWORDS, only the ones you've tested.

Take another shot at it if you like or we'll get around to it.  Thanks.
Comment 3 Christoph Brill (egore) (RESIGNED) 2004-03-07 13:51:06 UTC
Created attachment 27004 [details]
games-action/towbowl-tactics-0.5.ebuild

Fixed
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2004-03-07 16:39:49 UTC
Much much nicer.  Is it required to modify config.xml after the emake?  If not,
that should be moved to the unpack as well.

Instead of using /var/games directly, please use GAMES_STATEDIR from the games
eclass.

Just run sed once on the Makefile and use -e like this:

sed -i \
    -e "sed stuff here" \
    -e "more sed stuff" Makefile \
        || die "sed Makefile failed"

notice that we need to check the exit status of sed to make sure it works.

The dodir and move shouldn't be necessary in src_install if the Makefile gets
it right.

config.xml shouldn't be writable by everyone, just the group.  use fperms 664.

emake and make install are both external programs so should have error
checking/messages, like this:

emake || die "emake failed"
make ... install || die "make install failed"
Comment 5 Christoph Brill (egore) (RESIGNED) 2004-03-08 00:10:28 UTC
Created attachment 27013 [details]
games-action/towbowl-tactics-0.5.ebuild

Hopefully fixed it ... finally :)

Thanks for the help.
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2004-03-09 00:51:45 UTC
added games-action/twobowl-tactics to CVS.  Thanks for the bug report and ebuild.
Comment 7 Christoph Brill (egore) (RESIGNED) 2004-03-09 10:22:34 UTC
sorry, but the name of this game is towbowl, not twobowl
Comment 8 Mr. Bones. (RETIRED) gentoo-dev 2004-03-09 10:49:02 UTC
Doh!

fixed.