Created attachment 326530 [details, diff] diff to change clementine-1.1.0_rc1 to enable spotify blob downloader The clementine ebuild does not build Clementine with Spotify support. It can be easily enabled, and for me just works. Please see attached ebuild with an use flag, which adds a few libraries and changes compile configure options. (I'm not sure about the compiling setting changes being disabled if the use flag is NOT set - I'm not an ebuild expert by any means!) There may be licensing issues. However, there is an option which does not build or install any spotify libraries when compiling and / or installing, but instead the binary blob is downloaded at run time if user tries to use Spotify part (into ~/.config/Clementine). The attached ebuild uses this approach. Cheers!
Does it work without spotify packages installed?
Yes, at least for me. The spotify core code and blob downloader does require protobuf and qca, according to clementine's documentation. But I had them already installed because of other packages pulling them in. They are already in my patch, however. The documentation does list libspotify as a requirement, too, but I guess that is only in the case you want to compile the blob yourself (the documentation is not clear on this). Actually, at first I tried to compile Clementines Spotify binary blob myself with libspotify installed, but couldn't get that to compile, probably because Clementine code was made against an older version of libspotify currently available. So, just in case someone want's to add the blob to the ebuild - that might be a little bit trickier (and does require license issues to be resolved / notified while installing the ebuild; well, actually Clementine never displays any license if I use the spotifyblob downloader, but I guess I have already accepted that when I subscribed to Spotify).
Spotify is now in the tree. It would be great if you could update the ebuild.
For Comment #3: Spotify is not needed (as the library that is downloaded is independent of it), but nevertheless, I agree - if there is no reason not to, please do add this to the tree.
Nikoli ping?
After some testing I've found that the downloader is not necessary if libspotify is already in the system. The required "spotify blob" can be built from clementine sources (1.1.1), linking against libspotify acquired directly from spotify developer site. Still needs support in the ebuild, tho. I've written a dirty ebuild for libspotify, but I need to study how to write ebuilds that meet quality standards before I publish it for review.
Ebuild for libspotify is here: https://bugs.gentoo.org/show_bug.cgi?id=321837
Created attachment 334958 [details, diff] Diff against clementine-1.1.1.ebuild, enabling spotify Proposing an alternate change to enable spotify by building the needed "spotify blob" locally against libspotify. Removes the need to download binaries run-time to enable spotify functionality. Depends on libspotify and as a consequence, on bug 321837 resolution.
Will this make its way into portage? I feel like manually creating an overlay for Clementine is troubling because of future updates.
(In reply to Markos Chandras from comment #5) > Nikoli ping? that
Let use system libspotify, attached patch from Yliuntinen seems mostly fine. But we can not add spotify USE to clementine until required version of libspotify is in portage, bug #321837 should be fixed first.
libspotify doesn't exist anymore upstream, and we can't rely on https://mopidy.github.io/libspotify-archive/ to be kept up to date The build-in downloader downloaded from https://spotify.clementine-player.org/ these days simply redirects to https://github.com/clementine-player/Clementine/releases without any libspotify blobs
