Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 436924 - sys-devel/gcc-4.7.x: pie esp patches missing changes
Summary: sys-devel/gcc-4.7.x: pie esp patches missing changes
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: The Gentoo Linux Hardened Team
Depends on:
Reported: 2012-10-02 04:43 UTC by SpanKY
Modified: 2015-12-05 06:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2012-10-02 04:43:39 UTC
the 01_all_gcc47_configure.patch pie patch is missing the source hunks (namely the pieces)

further, it's slightly buggy.  configure spits out:
/var/tmp/portage/cross-x86_64-x32-linux-gnu/gcc-4.7.2/work/gcc-4.7.2/gcc/configure: line 27530: test: =: unary operator expected

which corresponds to a test of enable_esp but apparently that variable hasn't been initialized yet
Comment 1 Magnus Granberg gentoo-dev 2012-10-03 20:01:34 UTC
Have updated the piepatchset to 0.5.4 with the needed fix.
so test if is still there.
Comment 2 SpanKY gentoo-dev 2012-10-04 04:29:44 UTC
the .ac file doesn't match the generated output

it says:
+      enable_espf=yes
the variable is "enable_esp".  this comes up a few times.

the indentation on the gcc/ needs fixing, and it mixes tabs & spaces

i don't see the point in having "set_enable_esp" independent of "enable_esp".  just reset the value to "no" if you detect an unsupported case.

also, please keep them in a single patch rather than splitting it up
Comment 3 SpanKY gentoo-dev 2012-10-04 04:31:32 UTC
the code also talks about "x86_x32" targets, but there is no such thing.  i'm guessing you want to change "x86_??" (which wouldn't match x86_x32 anyways) to just x86_64.  the x32 ABI uses an x86_64-* tuple.
Comment 4 SpanKY gentoo-dev 2015-12-05 06:13:29 UTC
the biggest issues have been fixed, and the older versions are being cycled out, so i guess no need to spend time updating patches we aren't applying anymore