Bug 432876 – www-plugins/gnash-0.8.10-r2: patches for gcc-4.7, boost-1.50, kde4-plugindir etc.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andreas Sturmlechner 2012-08-26 15:26:42 UTC]

So I was browsing gnash.git for a gcc-4.7 fix and found several others maybe worth adding.

[Comment 1 Andreas Sturmlechner 2012-08-26 15:27:58 UTC]

Created attachment 322280 [details, diff]
gnash-0.8.10-gcc-4.7.patch

# Fix build with gcc-4.7 for bug #423675

[Comment 2 Andreas Sturmlechner 2012-08-26 15:30:08 UTC]

Created attachment 322282 [details, diff]
gnash-0.8.10-kde4-plugindir.patch

# Fix --with-kde4-plugin path http://savannah.gnu.org/bugs/?35675

I'm not sure what it does as it wasn't previously enabled in the gentoo ebuild, anyway adding the --with-kde4-plugin flag does work with this patch.

[Comment 3 Andreas Sturmlechner 2012-08-26 15:31:52 UTC]

Created attachment 322284 [details, diff]
gnash-0.8.10-fix-npstring-nullpointer-crash.patch

# Fix plugin crash http://savannah.gnu.org/bugs/?36002

[Comment 4 Andreas Sturmlechner 2012-08-26 15:33:58 UTC]

Created attachment 322286 [details, diff]
gnash-0.8.10-fix-compiler-warnings.patch

Silences several compiler warnings

[Comment 5 Andreas Sturmlechner 2012-08-26 15:35:22 UTC]

Created attachment 322288 [details, diff]
gnash-0.8.10-boost-1.50.patch

# Fix (?) for boost-1.50 picked from http://pkgs.fedoraproject.org/cgit/gnash.git/tree

I haven't unmasked boost-1.50 yet so I can't test this patch myself right now.

[Comment 6 Andreas Sturmlechner 2012-08-26 15:39:34 UTC]

(In reply to comment #2)
> # Fix --with-kde4-plugin path http://savannah.gnu.org/bugs/?35675
...that should have meant '--with-kde4-plugindir' of course...

[Comment 7 Andreas Sturmlechner 2012-08-26 15:49:40 UTC]

Created attachment 322290 [details, diff]
gnash-0.8.10-r3.ebuild.diff

Patches work altogether and gnash builds fine for me.

[Comment 8 Chí-Thanh Christopher Nguyễn 2012-09-01 00:56:58 UTC]

Instead of littering FILESDIR with patches, I might roll a snapshot of current git as there are more fixes that users probably want.

[Comment 9 Andreas Sturmlechner 2012-09-01 08:36:30 UTC]

That makes a lot of sense too. Also, there are recent hardening patches in master.

I've only picked non-scary patches though, so that might be easier to stabilise.

[Comment 10 Chí-Thanh Christopher Nguyễn 2012-10-16 00:26:46 UTC]

Fixed in CVS.