A normal bump request :) althought, it might need 1 new package: libnetfilter_acct libnetfilter_acct: as a dependency for flexible traffic accounting via nfnetlink_acct and iptables nfacct match (it requires Linux kernel >= 3.3.x). Reproducible: Always
This package needs a proxy maintainer for this and libnetfilter_acct: http://www.gentoo.org/proj/en/qa/proxy-maintainers/
(In reply to comment #1) > This package needs a proxy maintainer for this and libnetfilter_acct: > http://www.gentoo.org/proj/en/qa/proxy-maintainers/ Are there any prerequisites for a canditate? I would like to volunteer for ulogd and libnetfilter_acct. I am maintaining this in my local overlay anyway.
(In reply to comment #1) > This package needs a proxy maintainer for this and libnetfilter_acct: > http://www.gentoo.org/proj/en/qa/proxy-maintainers/ What's wrong with libnetfilter_acct? Netmon tries to bump it as soon as new version is out...
(In reply to comment #2) > (In reply to comment #1) > > This package needs a proxy maintainer for this and libnetfilter_acct: > > http://www.gentoo.org/proj/en/qa/proxy-maintainers/ > > Are there any prerequisites for a canditate? I would like to volunteer for > ulogd and libnetfilter_acct. I am maintaining this in my local overlay > anyway. Will CC proxy-maintainer people to let them know you are interested (In reply to comment #3) > (In reply to comment #1) > > This package needs a proxy maintainer for this and libnetfilter_acct: > > http://www.gentoo.org/proj/en/qa/proxy-maintainers/ > > What's wrong with libnetfilter_acct? Netmon tries to bump it as soon as new > version is out... Anyway, I guess he could co-maintain it, no? :/
(In reply to comment #4) > Will CC proxy-maintainer people to let them know you are interested Thank you!
Created attachment 332248 [details] proposed ebuild for ulogd-2.0.1 Totally forgot to attach all this.
Created attachment 332250 [details] ulogd initscript
Created attachment 332252 [details] ulogd logrotate Please note `create` directive in logrotate script. If logfile (current, not rotated) is not owned by `ulogd` user (or whatever user we are running as) ulogd will silently crash during reopen_logs.
> (In reply to comment #3) > > (In reply to comment #1) > > > This package needs a proxy maintainer for this and libnetfilter_acct: > > > http://www.gentoo.org/proj/en/qa/proxy-maintainers/ > > > > What's wrong with libnetfilter_acct? Netmon tries to bump it as soon as new > > version is out... > > Anyway, I guess he could co-maintain it, no? :/ Personally, i do not mind adding new maintainer(and proxy maintainers team) to co-maintainers for libnetfilter_acct.
(In reply to comment #5) > (In reply to comment #4) > > Will CC proxy-maintainer people to let them know you are interested > > Thank you! Yes, we will help you pushing this ebuild. Just give us sometime to review it
(In reply to comment #9) > > (In reply to comment #3) > > > (In reply to comment #1) > > > > This package needs a proxy maintainer for this and libnetfilter_acct: > > > > http://www.gentoo.org/proj/en/qa/proxy-maintainers/ > > > > > > What's wrong with libnetfilter_acct? Netmon tries to bump it as soon as new > > > version is out... > > > > Anyway, I guess he could co-maintain it, no? :/ > > Personally, i do not mind adding new maintainer(and proxy maintainers team) > to co-maintainers for libnetfilter_acct. Cool, thanks! Hope I could be helpful.
(In reply to comment #10) > (In reply to comment #5) > > (In reply to comment #4) > > > Will CC proxy-maintainer people to let them know you are interested > > > > Thank you! > > Yes, we will help you pushing this ebuild. Just give us sometime to review it That's great. Are there any actions required from my side? Maybe there's some guide about it or wiki page?
(In reply to comment #12) > (In reply to comment #10) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > Will CC proxy-maintainer people to let them know you are interested > > > > > > Thank you! > > > > Yes, we will help you pushing this ebuild. Just give us sometime to review it > > That's great. Are there any actions required from my side? Maybe there's > some guide about it or wiki page? What would you like to know? No actions are required apart from fixing the bugs for your package. You may also want to have a look on the project page http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
(In reply to comment #13) > What would you like to know? No actions are required apart from fixing the > bugs for your package. You may also want to have a look on the project page > > http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml I was wondering if there are some formal things I have to do. Fixing bugs and maintaining is assumed automatically. Thanks for the link. I still have some questions on how typical workflow around bugs happen, but I guess it is better to ask it in a more appropriate place. As far as I understood from the link you gave me there should be a person from a Proxy Maintaining Team who is my assigned Commiter, am I right? How do I know who is it? I'd like to ask him directly instead of further discussing it in this bug comments.
(In reply to comment #14) > (In reply to comment #13) > > What would you like to know? No actions are required apart from fixing the > > bugs for your package. You may also want to have a look on the project page > > > > http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml > > I was wondering if there are some formal things I have to do. Fixing bugs > and maintaining is assumed automatically. Thanks for the link. > > I still have some questions on how typical workflow around bugs happen, but > I guess it is better to ask it in a more appropriate place. As far as I > understood from the link you gave me there should be a person from a Proxy > Maintaining Team who is my assigned Commiter, am I right? How do I know who > is it? I'd like to ask him directly instead of further discussing it in this > bug comments. Just email the entire team. You don't have a dedicated committer. Anyone of us can commit your fixes.
A couple of comments: - your ebuild must not have stable keywords if you tried running "repoman full" on it you could see some fatal failures such as app-admin/ulogd/ulogd-2.0.1.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/10.0) ['>=net-libs/libnetfilter_acct-1.0.1', 'dev-libs/libdbi'] it's because it is dev-db/libdbi and NOT dev-lbis/libdbi also, libnetfilter_acct is not keyworded for ppc, so your ebuild must not have ppc keyword in it. Please fix your ebuild and always run repoman full before you submit it.
*** Bug 449690 has been marked as a duplicate of this bug. ***
Created attachment 334068 [details] ulogd-2.0.1.ebuild Sorry for a really big delay since last comment. I was busy with my finals then with New Year's madness. Happy New Year everyone, hence it's a bit late. Attached file is an edited version of ebuild, list of changes: * keyworded unstable (~amd64, ~x86) * proper libdbi package naming * dropped arches not supported by libnetfilter_acct. I really don't know why libnetfilter_acct doesn't support anything more than x86 & amd64. Should I file a bug? Anyway, several libnetfilter_* deps will become optional in a next release of ulogd and libnetfilter_acct is among them. Thanks to Markos for pointing me in the right direction and introducing repoman tool to me.
Created attachment 334070 [details] ulogd.logrotate Slightly updated logrotate script: prevent it from generating useless output to stdout.
(In reply to comment #18) > * dropped arches not supported by libnetfilter_acct. I really don't know why > libnetfilter_acct doesn't support anything more than x86 & amd64. Because nobody has tested it on those arches, i think. > Should I file a bug? Yes, please, this bug will be dependency of this one.
Created attachment 334218 [details] ulogd-2.0.1.ebuild Minor changes: use internal portage functions instead of direct chown/chmod calls, add postinst elog message about necessary config changes which should be enough for #375777
Created attachment 335054 [details] ulogd-2.0.1.ebuild Create ulogd homedir (/var/log/ulogd) only if needed.
Created attachment 340988 [details] ulogd.init Update copyright terms.
Created attachment 340990 [details] metadata.xml
Created attachment 340992 [details] ulogd-2.0.2.ebuild ulogd verbump. changelog: * input plugins are now optional * make more output plugins optional too, like pcap and sqlite. Though they are not truly optional i.e. they will be built anyway if appropriate packages are installed in your system, but I think it is nice not to force user to install them unconditionally. * add checks for kernel version, since some features like NFACCT require pretty recent kernel (>=3.3.0) * depend on linuxdoc-tools[latex] (see bug 375825)
@proxy-maint team, how about moving this into the tree? ulogd-1.* branch haven't seen changes for about 5 years from now. Bugs filed against app-admin/ulogd-2.0.0_beta4 are all addressed in ebuilds attached here and bugs against ulogd-1.* are simply obsolete by now. Since libnetfilter_acct is optional since 2.0.2 I am feeling like removing bug 450016 from deps of this one. What do you think?
Created attachment 340996 [details] ulogd-2.0.2.ebuild Minor changes: depend on virtual/latex-base rather than linuxdoc-tools[latex] as latter one brings also *.sty files with it.
(In reply to comment #25) > * make more output plugins optional too, like pcap and sqlite. Though they > are > not truly optional i.e. they will be built anyway if appropriate packages > are > installed in your system, but I think it is nice not to force user to > install > them unconditionally. Perhaps you should fix automagick in the build system then.
(In reply to comment #28) > (In reply to comment #25) > > * make more output plugins optional too, like pcap and sqlite. Though they > > are > > not truly optional i.e. they will be built anyway if appropriate packages > > are > > installed in your system, but I think it is nice not to force user to > > install > > them unconditionally. > > Perhaps you should fix automagick in the build system then. OK, that sounds like a good idea. Maybe you know a package in the tree that already does that so I won't have to reinvent the wheel?
Hi, (In reply to comment #29) > OK, that sounds like a good idea. Maybe you know a package in the tree that > already does that so I won't have to reinvent the wheel? Exact fix depends on your build system. Good guide is here: http://www.gentoo.org/proj/en/qa/automagic.xml
(In reply to comment #30) > Hi, > > (In reply to comment #29) > > OK, that sounds like a good idea. Maybe you know a package in the tree that > > already does that so I won't have to reinvent the wheel? > > Exact fix depends on your build system. Good guide is here: > http://www.gentoo.org/proj/en/qa/automagic.xml Thank you, Andrew. This link is very helpful.
Created attachment 342060 [details, diff] ulogd-2.0.2-automagic.patch
Created attachment 342062 [details] ulogd-2.0.2-r1.ebuild Add patch to fix automagic support of dbi, pcap and sqlite3 output plugins.
So, once again @proxy-main team what do you think about adding this verion to the tree?
(In reply to comment #34) > So, once again @proxy-main team what do you think about adding this verion > to the tree? Yes. Did you send ulogd-2.0.2-automagic.patch upstream?
Well, it is attached here in this bug. I am newbie in proxy-maintaining, should I also send it somewhere else?
(In reply to comment #36) > Well, it is attached here in this bug. I am newbie in proxy-maintaining, > should I also send it somewhere else? You should also send it to upstream developers to include it in the next release (if they find it useful otherwise you will have to rewrite it for every version bump if needed) http://netfilter.org/projects/ulogd/index.html
Created attachment 342630 [details] ulogd-2.0.2.ebuild Improved ebuild for ulogd-2.0.2: - some QA fixes, alphabetical sort of dependencies, IUSE, src_configure options, etc; - improved readability of sed statement; - move fowners and fperms from pkg_preinst to src_install; - add keepdir for /var/log/ulogd instead of checkpath in pkg_setup; - replace die about nfacct plugin and kernel <= 3.3 with ewarn - ulogd build fine with older kernels and this plugin enabled; - use readme.gentoo eclass; - prune unnecessary libtool files for modules.
Created attachment 342634 [details] ulogd-2.0.2.ebuild Err, there was mistake in previous ebuild in keepdir statement - it was '/var/run/ulogd' and it should be '/var/log/ulogd' - we should create directory for logfiles.
(In reply to comment #39) > Created attachment 342634 [details] > ulogd-2.0.2.ebuild > > Err, there was mistake in previous ebuild in keepdir statement - it was > '/var/run/ulogd' and it should be '/var/log/ulogd' - we should create > directory for logfiles. The ebuild looks good to me. please commit
(In reply to comment #37) > (In reply to comment #36) > > Well, it is attached here in this bug. I am newbie in proxy-maintaining, > > should I also send it somewhere else? > > You should also send it to upstream developers to include it in the next > release (if they find it useful otherwise you will have to rewrite it for > every version bump if needed) > > http://netfilter.org/projects/ulogd/index.html Oh, ulogd's upstream. I've thought of gentoo cvs tree. Yeah, I'll sure send this patch there.
And thanks(In reply to comment #39) > Created attachment 342634 [details] > ulogd-2.0.2.ebuild > > Err, there was mistake in previous ebuild in keepdir statement - it was > '/var/run/ulogd' and it should be '/var/log/ulogd' - we should create > directory for logfiles. Sergey, thank you very much for your ebuild corrections and improvements.
(In reply to comment #40) > (In reply to comment #39) > > Created attachment 342634 [details] > > ulogd-2.0.2.ebuild > > > > Err, there was mistake in previous ebuild in keepdir statement - it was > > '/var/run/ulogd' and it should be '/var/log/ulogd' - we should create > > directory for logfiles. > > The ebuild looks good to me. please commit Great news! Thanks. This ebuild also addresses bugs #375777 and #375825, so could you please close them?
Ok, i will commit this after some small improvements and careful testing...
+ 20 Mar 2013; Sergey Popov <pinkbyte@gentoo.org> +ulogd-2.0.2.ebuild, + +files/ulogd-2.0.2-automagic.patch, +files/ulogd-2.init, + +files/ulogd-2.logrotate, metadata.xml: + Version bump, wrt bug #426868, fix bugs #375825 and #375777. Package will be + maintained by Coacher <itumaykin AT gmail.com> through proxy maintainers @Coacher, i remove keyword request on libnetfilter_acct from "Depends" on this bug. You should file rekeyword request on new version of ulogd(due to bunch of introduced dependencies) and add that bug in "Depends". More info - http://devmanual.gentoo.org/keywording/index.html Feel free to contact with proxy maintainers by e-mail or IRC if you need some clarification on maintaining procedures.
Created attachment 342712 [details] ulogd-2.0.2-r1.ebuild Fix a small typo made by Sergey: double "ulogd.conf.in" in sed call which results in paths being "/var/log/ulogd/ulogd/" instead of simply "/var/log/ulogd". P.S. I can't make your attachment obsolete which sucks so here's revbump.
(In reply to comment #37) > (In reply to comment #36) > > Well, it is attached here in this bug. I am newbie in proxy-maintaining, > > should I also send it somewhere else? > > You should also send it to upstream developers to include it in the next > release (if they find it useful otherwise you will have to rewrite it for > every version bump if needed) > > http://netfilter.org/projects/ulogd/index.html Done. Author agreed to merge this into their git so next version should be fixed.
(In reply to comment #45) > + 20 Mar 2013; Sergey Popov <pinkbyte@gentoo.org> +ulogd-2.0.2.ebuild, > + +files/ulogd-2.0.2-automagic.patch, +files/ulogd-2.init, > + +files/ulogd-2.logrotate, metadata.xml: > + Version bump, wrt bug #426868, fix bugs #375825 and #375777. Package will > be > + maintained by Coacher <itumaykin AT gmail.com> through proxy maintainers > > @Coacher, i remove keyword request on libnetfilter_acct from "Depends" on > this bug. You should file rekeyword request on new version of ulogd(due to > bunch of introduced dependencies) and add that bug in "Depends". More info - > http://devmanual.gentoo.org/keywording/index.html > > Feel free to contact with proxy maintainers by e-mail or IRC if you need > some clarification on maintaining procedures. Done. https://bugs.gentoo.org/show_bug.cgi?id=462480
+ 20 Mar 2013; Sergey Popov <pinkbyte@gentoo.org> ulogd-2.0.2.ebuild: + Fix a typo in sed statement, wrt bug #426868, thanks to Coacher <itumaykin AT + gmail.com>
