Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 426322 - sys-apps/coreutils-8.17: Merge Gentoo Prefix support
Summary: sys-apps/coreutils-8.17: Merge Gentoo Prefix support
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: Goal, Inclusion, InOverlay
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-07-12 14:22 UTC by Richard Yao (RETIRED)
Modified: 2012-11-13 08:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Darkside's patch (coreutils-prefix.diff,4.26 KB, patch)
2012-07-12 14:22 UTC, Richard Yao (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2012-07-12 14:22:05 UTC
Created attachment 318000 [details, diff]
Darkside's patch

Darkside wrote a patch so that prefix support could be merged from the prefix overlay. He doesn't have time to persue it right now, so I am volunteering to take up the cause.

His patch applies the following via epatch, which will need to be moved to the patch set:

http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/sys-apps/coreutils/files/coreutils-7.2-mint.patch

I do not know exactly what platform benefits from that and I also don't have access to it to test it. grobian is the one who committed that patch, so I hope he can shed some light on it.

Also, this will result in patches that support Interix and HP-UX being removed from Gentoo Prefix, which is unfortunate.

http://overlays.gentoo.org/proj/alt/browser/trunk/prefix-overlay/sys-apps/coreutils/files?order=name

I believe that The_Paya uses Prefix on HP-UX, so I am putting him on CC. Hopefully, he will be able to tell us whether or not coreutils works with those patches and we could get them sent upstream.
Comment 1 Fabian Groffen gentoo-dev 2012-07-12 16:06:13 UTC
I'd prefer to first get the ebuild changed in Prefix overlay to match whatever we'd like it to be, and be what gx86 should/could have.  Now this patch your suggest is neither gx86 or prefix version.
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-07-12 16:11:52 UTC
(In reply to comment #1)
> I'd prefer to first get the ebuild changed in Prefix overlay to match
> whatever we'd like it to be, and be what gx86 should/could have.  Now this
> patch your suggest is neither gx86 or prefix version.

My patch you mean. I already took the time to get it to be what gx86 should have and you invalidated it ;)
Comment 3 Fabian Groffen gentoo-dev 2012-07-12 16:41:53 UTC
yup, if we break coreutils, we're really busted if we can't make a quick fix (any more)
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-07-13 12:58:47 UTC
base-system: Can Richard apply coreutils-7.2-mint.patch to the coreutils patchset? The ebuild was already reviewed and accepted via Samuli@IRC so this is the last open pending question. Thanks.
Comment 5 SpanKY gentoo-dev 2012-07-15 22:42:26 UTC
Comment on attachment 318000 [details, diff]
Darkside's patch

all this mint junk is fairly intrusive.  why does it have to be special ?  certainly without documentation on its deviation, this can't be merged.

the D->ED and ROOT->EROOT changes are fine of course
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-07-16 15:31:39 UTC
Alan, why does the coreutils ebuild need special cases for mint to install different programs? (comment #5)
Comment 7 Alan Hourihane 2012-07-16 15:43:03 UTC
Take "hostname". On Linux this is provided by net-tools, but that's a very linux specific package, and that hasn't been ported to prefix.
And for "uptime" and "kill" they're provided by sys-process/procps, again linux specific at this time.

I don't have these three commands.
Comment 8 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-07-16 15:50:28 UTC
Alright, one could generalize that the mint specific code in the ebuild is to install applications that the host system does not provide and there are no alternative packages available, like on linux.

@vapier, what part do you consider intrusive to be fixed?
Comment 9 Javier Villavicencio (RETIRED) gentoo-dev 2012-07-22 17:59:00 UTC
(In reply to comment #0)
> I believe that The_Paya uses Prefix on HP-UX, so I am putting him on CC.
> Hopefully, he will be able to tell us whether or not coreutils works with
> those patches and we could get them sent upstream.

Negative, I have prefix installs in Solaris 10 and AIX 5.2/5.3 ^_^.
Comment 11 SpanKY gentoo-dev 2012-11-13 05:39:20 UTC
(In reply to comment #10)

changes to lib/ must go to upstream gnulib.  we're not going to carry patches to coreutils' gnulib for anything other than short term fixes.

the coreutils guys are very good about merging back the latest gnulib when making a new release.
Comment 12 Fabian Groffen gentoo-dev 2012-11-13 08:00:59 UTC
Oh man what a mess is this bug.  Let's revisit this one once we did our homework on coreutils properly in our overlay.