Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 425958 - mail-filter/milter-regex: LICENSE variable does not reflect init script
Summary: mail-filter/milter-regex: LICENSE variable does not reflect init script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Ralph Seichter
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: init-script-license
  Show dependency tree
 
Reported: 2012-07-11 17:18 UTC by Ian Stakenvicius (RETIRED)
Modified: 2022-11-02 14:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Stakenvicius (RETIRED) gentoo-dev 2012-07-11 17:18:50 UTC
The init script(s) provided in FILESDIR for mail-filter/milter-regex has a license of GPL-2 but GPL-2 isn't within the LICENSE variable of the ebuild(s):

files/milter-regex-init has license line:
# Distributed under the terms of the GNU General Public License v2
... and is used by the following ebuilds:
milter-regex-1.7-r2.ebuild:LICENSE="BSD"
milter-regex-1.8.ebuild:LICENSE="BSD"

There are two options here -- either LICENSE in the ebuilds should be appended with GPL-2 to cover the init script, or the init script should be relicensed so that it is covered by current LICENSE (this one is probably the preferred resolution).  See also bug 425702 .
Comment 1 Ralph Seichter 2022-10-01 18:24:50 UTC
This issue has been open for 10 years (!), long before I ever got involved with the ebuild. Please find somebody else but me (i.e. somebody knowledgeable about the legal side of things) to deal with this.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-01 18:35:37 UTC
(In reply to Ralph Seichter from comment #1)
> This issue has been open for 10 years (!), long before I ever got involved
> with the ebuild. Please find somebody else but me (i.e. somebody
> knowledgeable about the legal side of things) to deal with this.

The instructions seem pretty clear in the last paragraph but in any case, reassigning to proxy-maint is a deadend and not keeping yourself in CC is very odd.
Comment 3 Ralph Seichter 2022-10-01 18:50:08 UTC
(In reply to Sam James from comment #2)
> The instructions seem pretty clear in the last paragraph
Good for you. To me, they are not clear.

> reassigning to proxy-maint is a deadend
That's worrying to hear.

> not keeping yourself in CC is very odd.
I'll add myself in Cc to appease you, but please do not re-assign the issue to me. I simply don't have sufficient legal knowledge to deal with it. According to the homepage https://www.benzedrine.ch/milter-regex.html, milter-regex is BSD licensed, however that fits in Gentoo ebuild licensing.
Comment 4 Ionen Wolkens gentoo-dev 2022-10-01 19:08:02 UTC
bug wranglers will just assign bugs based on the metadata.xml, which is what I'm doing right now

Also I'm not sure what requires legal knowledge here, this is just about populating LICENSE for all files that are installed (LICENSE isn't only the "main" license for a package, will have multiple depending on what's used).

See devmanual, may help:
https://devmanual.gentoo.org/general-concepts/licenses/index.html
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-01 19:08:52 UTC
proxy-maint is a project for proxying commits. It's not some generic thing to dump bugs on.

The comment clearly says to just add GPL-2...? You don't need legal knowledge to see that the header of the init script says something and therefore LICENSE should include it. The devmanual covers LICENSE.

It's your package and it's an easy fix?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-01 19:09:19 UTC
(Sorry, collided on mobile and hit wrong button)
Comment 7 Larry the Git Cow gentoo-dev 2022-11-02 14:24:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bbf239910090ec61430dc07c32c6c662207948c9

commit bbf239910090ec61430dc07c32c6c662207948c9
Author:     Ralph Seichter <github@seichter.de>
AuthorDate: 2022-10-18 07:15:20 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-11-02 14:24:25 +0000

    mail-filter/milter-regex: Expand LICENSE variable
    
    Include GPL v2 (license for the init file)
    
    Closes: https://bugs.gentoo.org/425958
    Signed-off-by: Ralph Seichter <github@seichter.de>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../milter-regex/milter-regex-2.7-r3.ebuild        | 47 ++++++++++++++++++++++
 1 file changed, 47 insertions(+)