Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 420735 - repoman commit: please update ChangeLog before updating Manifest (if possible)
Summary: repoman commit: please update ChangeLog before updating Manifest (if possible)
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 423075
  Show dependency tree
 
Reported: 2012-06-11 21:01 UTC by Michał Górny
Modified: 2012-06-23 07:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-06-11 21:01:40 UTC
I used to use the following work flow:

1) repoman commit --ask ... -- to perform repoman checks, update the Manifests,
2) test the package using emerge,
3) answer 'yes' to commit.

That doesn't work any longer with --echangelog=y as it updates the ChangeLog after regenerating Manifest and thus makes it no longer valid. I'd appreciate if the Manifest update could either be delayed, or ChangeLog update moved earlier (or even later, i.e. after asking).
Comment 1 Zac Medico gentoo-dev 2012-06-11 23:18:22 UTC
(In reply to comment #0)
> I used to use the following work flow:
> 
> 1) repoman commit --ask ... -- to perform repoman checks, update the
> Manifests,
> 2) test the package using emerge,
> 3) answer 'yes' to commit.

Seems like an odd workflow. I guess that most people test the package with emerge before they issue the repoman commit command.

> That doesn't work any longer with --echangelog=y as it updates the ChangeLog
> after regenerating Manifest and thus makes it no longer valid. I'd
> appreciate if the Manifest update could either be delayed, or ChangeLog
> update moved earlier (or even later, i.e. after asking).

We could easily regenerate the corresponding Manifest immediately after each ChangeLog is modified.
Comment 3 Zac Medico gentoo-dev 2012-06-12 02:20:14 UTC
Here's a little tweak so that it only regenerates the Manifest when --ask it specified:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=8063586060f7d4abfa02639ba72c0e9b38ed634a
Comment 4 Zac Medico gentoo-dev 2012-06-23 07:39:30 UTC
This is fixed in 2.1.11 and 2.2.0_alpha111.