Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 419717 - repoman commit tries to sign Manifest for ebuilds with no distfiles on thin-manifest overlays
Summary: repoman commit tries to sign Manifest for ebuilds with no distfiles on thin-m...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL: http://archives.gentoo.org/gentoo-por...
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 423075
  Show dependency tree
 
Reported: 2012-06-05 08:09 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-06-23 07:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-06-05 08:09:19 UTC 
You need a passphrase to unlock the secret key for
user: "Diego Elio Pettenò (Manifest Signing Key) <flameeyes@gentoo.org>"
2048-bit RSA key, ID D4301342, created 2012-04-28

gpg: impossibile aprire `/home/flame/devel/repos/flameeyes-overlay/app-text/scan2pdf/Manifest': File o directory non esistente
gpg: /home/flame/devel/repos/flameeyes-overlay/app-text/scan2pdf/Manifest: clearsign failed: File o directory non esistente
!!! !!! gpg exited with '512' status
!!! Disabled FEATURES='sign'

(The italian errors are "can't open" and "file does not exist".)

This is set in metadata/layout.conf to have thin-manifests...
Comment 1 Zac Medico gentoo-dev 2012-06-05 08:22:02 UTC 
I'm not sure what the desired behavior is. Should it create an empty Manifest and then sign it?
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-06-05 12:40:21 UTC 
I think it should understand there's not going to be a Manifest, so there is no reason to try signing it to begin with...
Comment 3 Zac Medico gentoo-dev 2012-06-05 22:52:31 UTC 
@Robin: My original instinct was to disable manifest signing for thing manifests. How do you think it should behave if the manifest is supposed to be empty (no distfiles)?
Comment 4 Brian Harring (RETIRED) gentoo-dev 2012-06-06 00:49:18 UTC 
(In reply to comment #3)
> @Robin: My original instinct was to disable manifest signing for thing
> manifests. How do you think it should behave if the manifest is supposed to
> be empty (no distfiles)?

If you're signing the underlying commits, there's no reason to sign the manifest.

For infra (git->rsync generation), during the conversion it would generate signed manifests for rsync users, but for people accessing git, as said, it's redundant.
Comment 5 Zac Medico gentoo-dev 2012-06-06 01:23:23 UTC 
(In reply to comment #4)
> If you're signing the underlying commits, there's no reason to sign the
> manifest.

Yeah, I'm guessing that Diego probably doesn't have "sign-commits = true" in metadata/layout.conf, since if he had that then he probably would have also set "sign-manifests = false".

@Diego: Is using "sign-commits = true" (which only works with Git >=1.7.9) together with "sign-manifests = false" an option for you?
Comment 6 Zac Medico gentoo-dev 2012-06-06 01:36:23 UTC 
(In reply to comment #2)
> I think it should understand there's not going to be a Manifest, so there is
> no reason to try signing it to begin with...

Okay, this is fixed in git:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=9dbf4d7d7fb7c6d0284cc25d8322dd84292d6dd9
Comment 7 Zac Medico gentoo-dev 2012-06-23 07:39:17 UTC 
This is fixed in 2.1.11 and 2.2.0_alpha111.