Bug 419479 – vcs-snapshot.eclass - can't set ${S} to subdir of ${WORKDIR}/${P}

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ralph Sennhauser (RETIRED) 2012-06-03 13:53:07 UTC]

Setting S to a subdir of ${WORKDIR}/${P} as in S="${WORKDIR}/${P}/${PN}-core" will result in a failure as ${WORKDIR}/${P} doesn't exist yet.

I suggest to move to ${WORKDIR}/${P} instead of ${S} so the above will work. Thanks.

[Comment 1 Michał Górny 2012-06-04 07:40:06 UTC]

That would be actually not the behavior we are looking for, I think? Any reason just not to add 'mkdir' for parents there and move the stuff to yours ${S}? Or are you just building a sub-tree of the tarball?

[Comment 2 Ralph Sennhauser (RETIRED) 2012-06-04 09:43:30 UTC]

Yes, just building a subtree. The current solution is to not use vcs-snapshot.eclass

I was of the impression setting ${WORKDIR}/${P} was the intention all along and ${S} was used in an oversight. After all S defaults to ${WORKDIR}/${P} and using vcs-snapshot.eclass there is no need to touch S unless you are after a subtree.

[Comment 3 Michał Górny 2012-06-04 09:54:53 UTC]

(In reply to comment #2)
> I was of the impression setting ${WORKDIR}/${P} was the intention all along
> and ${S} was used in an oversight. After all S defaults to ${WORKDIR}/${P}
> and using vcs-snapshot.eclass there is no need to touch S unless you are
> after a subtree.

Yes, you're probably right. I am going to submit a patch for review today and commit it soon if no-one objects.

[Comment 4 Ralph Sennhauser (RETIRED) 2012-06-04 10:34:19 UTC]

(In reply to comment #3)
> Yes, you're probably right. I am going to submit a patch for review today
> and commit it soon if no-one objects.

Thanks.

[Comment 5 Michał Górny 2012-06-11 13:59:13 UTC]

Ah, I've committed the change a few days ago and forgot to close the bug.

[Comment 6 Ralph Sennhauser (RETIRED) 2012-06-11 14:54:45 UTC]

(In reply to comment #5)
> Ah, I've committed the change a few days ago and forgot to close the bug.

:), thanks.