Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 415001 - media-gfx/darktable-1.0.3 version bump
Summary: media-gfx/darktable-1.0.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Dane Smith (RETIRED)
URL: http://darktable.org/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 10:26 UTC by Serge Gavrilov
Modified: 2012-06-08 06:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
darktable-1.0.3.ebuild (darktable-1.0.3.ebuild,2.46 KB, text/plain)
2012-05-08 23:00 UTC, Mike Limansky 		Details
darktable-1.0.3-cflags.patch (darktable-1.0.3-cflags.patch,1.80 KB, patch)
2012-05-08 23:00 UTC, Mike Limansky 		Details | Diff
darktable-1.0.3-version-detect.patch (darktable-1.0.3-version-detect.patch,608 bytes, patch)
2012-05-08 23:00 UTC, Mike Limansky 		Details | Diff
darktable-1.0-1.0.4.ebuild.diff (darktable-1.0-1.0.4.ebuild.diff,404 bytes, patch)
2012-06-05 09:45 UTC, Mike Limansky 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Serge Gavrilov 2012-05-07 10:26:45 UTC 
darktable-1.0.3 released, please update the tree

Reproducible: Always
Comment 1 Mike Limansky 2012-05-08 23:00:02 UTC 
Created attachment 311207 [details]
darktable-1.0.3.ebuild

Hi all,

  I've prepare ebuild and patches for version 1.0.3. I've found that the GCC version is not handled properly in CMake file: the regex, used in CMakeLists.txt requires space character after version number, but there are no space in:

g++ (Gentoo 4.5.3-r2 p1.1, pie-0.4.7) 4.5.3
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

so I just remove it. Ebuild and patches are attached.
Comment 2 Mike Limansky 2012-05-08 23:00:28 UTC 
Created attachment 311209 [details, diff]
darktable-1.0.3-cflags.patch
Comment 3 Mike Limansky 2012-05-08 23:00:48 UTC 
Created attachment 311211 [details, diff]
darktable-1.0.3-version-detect.patch
Comment 4 Tim Harder gentoo-dev 2012-05-10 21:38:40 UTC 
(In reply to comment #1)
> Created attachment 311207 [details]
> darktable-1.0.3.ebuild

In the future, instead of a full ebuild please attach a unified diff between the most recent version in the tree and your ebuild so we can easily see what was changed.
Comment 5 Mike Limansky 2012-05-21 05:59:11 UTC 
(In reply to comment #4)
> (In reply to comment #1)
> > Created attachment 311207 [details]
> > darktable-1.0.3.ebuild
> 
> In the future, instead of a full ebuild please attach a unified diff between
> the most recent version in the tree and your ebuild so we can easily see
> what was changed.

Ok, next time I will. Are there any objections to integrate provided ebuild?
Comment 7 Mike Limansky 2012-06-05 09:45:44 UTC 
Created attachment 314269 [details, diff]
darktable-1.0-1.0.4.ebuild.diff

I've checked, new version doesn't require patch for gcc version. Diff between darktable-1.0 and 1.0.4 ebuilds is attached. The cflags patch is the same with version 1.0.3.
Comment 8 Tim Harder gentoo-dev 2012-06-08 06:29:50 UTC 
Thanks, added to CVS.