Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 413895 - Package-specific /etc/portage/env scripts should be sourced after /etc/portage/bashrc
Summary: Package-specific /etc/portage/env scripts should be sourced after /etc/portag...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, PATCH
Depends on:
Blocks: 409383
  Show dependency tree
 
Reported: 2012-04-28 20:06 UTC by James Le Cuirot
Modified: 2012-05-09 23:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-ebuild.sh-source-etc-portage-env-scripts-before-etc-.patch (0001-ebuild.sh-source-etc-portage-env-scripts-before-etc-.patch,1.40 KB, patch)
2012-04-28 20:06 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2012-04-28 20:06:34 UTC
Created attachment 310355 [details, diff]
0001-ebuild.sh-source-etc-portage-env-scripts-before-etc-.patch

It is a generally accepted convention that package-specific options should take priority over global ones and I think this should apply to the bashrc scripts as well. This currently isn't the case because /etc/portage/bashrc is sourced last. I spoke to mgorny, who implemented the per-package bashrc support and he agreed, stating that he didn't really consider the order at the time. Please see the attached patch. I have checked that the tests still pass.
Comment 1 Mira Ressel 2012-04-28 20:15:17 UTC
Shouldn't the title be exactly the other way round?
"Package-specific /etc/portage/env scripts should be sourced *after* /etc/portage/bashrc"
Comment 3 James Le Cuirot gentoo-dev 2012-04-28 22:05:52 UTC
(In reply to comment #1)
> Shouldn't the title be exactly the other way round?
> "Package-specific /etc/portage/env scripts should be sourced *after*
> /etc/portage/bashrc"

Erm yep, wrote that in a hurry!

Thanks for the quick merge, Zac.
Comment 4 Zac Medico gentoo-dev 2012-05-08 17:33:18 UTC
This is released for testing in 2.2.0_alpha102.
Comment 5 Zac Medico gentoo-dev 2012-05-09 23:16:07 UTC
This is fixed in 2.1.10.58.