413883 – dev-db/{mariadb,mysql}-5.5 remove hard mask

Bug 413883 - dev-db/{mariadb,mysql}-5.5 remove hard mask

Summary: dev-db/{mariadb,mysql}-5.5 remove hard mask

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Gentoo Linux MySQL bugs team

URL:
Whiteboard:
Keywords:

Depends on:	392361 395697 410001 412851
Blocks:
	Show dependency tree

Reported:	2012-04-28 17:28 UTC by J
Modified:	2012-11-02 00:22 UTC (History)
CC List:	5 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description J 2012-04-28 17:28:49 UTC

The comments surrounding the package.mask masking of mariadb-5.5 date from July 2011.

mariadb-5.5.23 was recently (April 11th) released upstream as stable.

The package is ~arch masked so it seems reasonable to remove the hard mask.

Reproducible: Always

Comment 1 Robin Johnson archtester

2012-04-28 20:36:07 UTC

Please see dependant bugs first.

Comment 2 Paolo Pedroni 2012-05-31 14:56:13 UTC

I don't understand what bug #412851 (which is about mariadb-5.1 and readline) has to do with the unmasking of mariadb-5.5. Can you please explain?

Comment 3 Francesco Riosa 2012-06-29 12:42:40 UTC

(In reply to comment #1)
> Please see dependant bugs first.

indeed the readline.cmake seem unused in 5.5 (but still present)

CMakeCache.txt contains:
READLINE_LIBRARY:FILEPATH=/usr/lib64/libreadline.so
//Use bundled readline
WITH_READLINE:BOOL=OFF
//Dependencies for the target
readline_LIB_DEPENDS:STATIC=general;-lpthread;general;/usr/lib64/libcurses.so;


upgrading to mariadb-5.5.23 should fix #412851

Comment 4 Francesco Riosa 2012-06-29 13:45:32 UTC

but tests are broken for out of tree builds (the standard in gentoo)

Comment 5 Brian Evans (RETIRED) gentoo-dev

2012-07-20 13:18:11 UTC

(In reply to comment #4)
> but tests are broken for out of tree builds (the standard in gentoo)

IMO, the tests should be structured like they are in the MySQL 5.5 ebuilds instead of the automake-based MariaDB 5.(1-3) ebuilds.
I've run them just fine that way.

My personal overlay, https://github.com/grknight/gentoo-mysql , reflects this.

Comment 6 Brian Evans (RETIRED) gentoo-dev

2012-07-27 16:35:09 UTC

The official mysql overlay has been updated with my changes thanks to Robin.

Please update and run tests on the MariaDB 5.5 builds now following the official instructions in the ebuild.

Comment 7 Brian Evans (RETIRED) gentoo-dev

2012-08-03 19:48:23 UTC

USE="minimal" is broken on >=MariaDB-5.5 (as well as >=mysql-5.5)

I'm working on it and will send patches to mysql team ASAP.

Comment 8 Robin Johnson archtester

2012-11-02 00:22:18 UTC

5.5 released now.