Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 411053 - media-video/mkvtoolnix: request to enable USE="wxwidgets" by default
Summary: media-video/mkvtoolnix: request to enable USE="wxwidgets" by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-06 16:10 UTC by Pacho Ramos
Modified: 2012-04-17 08:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-04-06 16:10:23 UTC
Even having gnome profile set on my systems (that enable gtk USE flag by default), I got surprised when I saw I had no GUI at all for mkvtoolnix package. That was caused by it using "wxwidgets" instead. That doesn't look too reasonable to me when no other gtk GUI alternative is provided and, then, I would move "wxwidgets" to "gtk" USE flag to get mkvtoolnix's gtk GUI installed

Thanks

Reproducible: Always
Comment 1 Tim Harder gentoo-dev 2012-04-07 07:27:28 UTC
No other ebuild in the tree appears to do this, probably due to the global definition for the gtk use flag stating the use of x11-libs/gtk+.

Anyway, I don't really see a need for this, but I'm partially biased since I never use the GUI anyway. :)
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2012-04-07 07:37:39 UTC
-1 from me, it's correct the way it is -- USE=wxwidgets is being used as designed
Comment 3 Pacho Ramos gentoo-dev 2012-04-07 11:59:46 UTC
But people having a global "gtk" USE flag set expects to have gtk based GUIs enabled, if it's being used "as designed" (I don't know where are that "designs" also) it's wrongly designed I think, as this packages doesn't have any other gtk gui available
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-04-07 20:43:10 UTC
I meant USE=wxwidgets is for controlling wxwidgets toolkit/gui as per description with 'as designed'.
I see 4 different ways of solving this: IUSE="+wxwidgets" or in desktop profile, 'media-video/mkvtoolnix wxwidgets' in package.use or 'wxwidgets' in make.defaults
if the latter, propose to enable it by default in the ML. Or do nothing and leave it the way it is.
Comment 5 Pacho Ramos gentoo-dev 2012-04-08 11:03:51 UTC
Maybe I should suggest in ML to USE "gtk" USE flag as first option when package doesn't have any other gtk gui than wxGTK based one, and, then, use "wxwidgets" when there is another "gtk" gui to fit there. That way would also fit inside "gtk" USE flag description:
gtk - Adds support for x11-libs/gtk+ (The GIMP Toolkit)
Comment 6 Alexis Ballier gentoo-dev 2012-04-08 14:03:49 UTC
why do you assume wxwidgets means gtk ?

from http://wxwidgets.org/downloads/ :

    wxMSW - installer for sources (not binaries) Windows, with manual
    wxGTK
    wxMac
    wxX11
    Other ports (Motif, OS/2, MGL, Base) and releases
Comment 7 Pacho Ramos gentoo-dev 2012-04-09 18:56:48 UTC
(In reply to comment #6)
> why do you assume wxwidgets means gtk ?


Because in this case it means gtk gui
Comment 8 Alexis Ballier gentoo-dev 2012-04-09 20:40:02 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > why do you assume wxwidgets means gtk ?
> 
> 
> Because in this case it means gtk gui

_today_
if some day we have have other wxwidgets implementations, we'll have to revert it.

gtk based desktop profiles should rather enable wxwidgets by default
Comment 9 Pacho Ramos gentoo-dev 2012-04-09 20:53:59 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > why do you assume wxwidgets means gtk ?
> > 
> > 
> > Because in this case it means gtk gui
> 
> _today_
> if some day we have have other wxwidgets implementations, we'll have to
> revert it.
> 

No, we will need to handle that new situation to allow people to select what implementation to use and, then, try to get gtk based GUIs build with gtk related profiles


> gtk based desktop profiles should rather enable wxwidgets by default
Comment 10 Alexis Ballier gentoo-dev 2012-04-09 21:13:39 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > why do you assume wxwidgets means gtk ?
> > > 
> > > 
> > > Because in this case it means gtk gui
> > 
> > _today_
> > if some day we have have other wxwidgets implementations, we'll have to
> > revert it.
> > 
> 
> No, we will need to handle that new situation to allow people to select what
> implementation to use and, then, try to get gtk based GUIs build with gtk
> related profiles

I dont understand what you meant and how this relates to this :(

(In reply to comment #5)
> Maybe I should suggest in ML to USE "gtk" USE flag as first option when
> package doesn't have any other gtk gui than wxGTK based one, and, then, use
> "wxwidgets" when there is another "gtk" gui to fit there. That way would
> also fit inside "gtk" USE flag description:
> gtk - Adds support for x11-libs/gtk+ (The GIMP Toolkit)


which, to me, makes as much sense as merging gtk and qt useflags under the X useflag because they both need X. Or rather, tell people to use the X useflag if qt or gtk is the only available gui.
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2012-04-09 21:18:37 UTC
(In reply to comment #9)

nah, it's mostly about platform/OS and you can't eselect that. 
aballier seems to be accurate, and I agree the only way to proceed here is to ask USE='wxwidgets' to be enabled by default in the desktop profile. it seems to make sense for the other packages using wxwidgets too, after quick grep through the tree.
so unless you are going to propose that in the ML, i'm inclined to close this as WONTFIX
Comment 12 Pacho Ramos gentoo-dev 2012-04-10 06:51:37 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > (In reply to comment #7)
> > > > (In reply to comment #6)
> > > > > why do you assume wxwidgets means gtk ?
> > > > 
> > > > 
> > > > Because in this case it means gtk gui
> > > 
> > > _today_
> > > if some day we have have other wxwidgets implementations, we'll have to
> > > revert it.
> > > 
> > 
> > No, we will need to handle that new situation to allow people to select what
> > implementation to use and, then, try to get gtk based GUIs build with gtk
> > related profiles
> 
> I dont understand what you meant and how this relates to this :(

You suggested that we should revert it if we, for example, include motif port, but I don't think having all that ports inside the same "wxwidgets" flag would be much sense :-/

(In reply to comment #11)
> (In reply to comment #9)
> 
> nah, it's mostly about platform/OS and you can't eselect that. 
> aballier seems to be accurate, and I agree the only way to proceed here is
> to ask USE='wxwidgets' to be enabled by default in the desktop profile. it
> seems to make sense for the other packages using wxwidgets too, after quick
> grep through the tree.
> so unless you are going to propose that in the ML, i'm inclined to close
> this as WONTFIX

Will mail to gentoo-dev as either wait (moving to "gtk" or enabling "wxwidgets" by default) will need discussion
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2012-04-10 07:05:15 UTC
there is just no way 'wxwidgets' is getting renamed to 'gtk', it's like Comment #10 says, same thing as renaming 'qt4' to 'gtk'
Comment 14 Ryan Hill (RETIRED) gentoo-dev 2012-04-11 00:15:37 UTC
Just change it to USE="+wxwidgets" or rename it "gui" or something.  I have no opinion about making it default in the profiles.  It's probably a good idea.  If you do, please make it default for desktop and not just desktop/gnome.

We're not renaming it "gtk".  They're completely different toolkits.  I have no plans to add other implementations until we get preserve-libs in stable or some kind of install-time library reverse-dependency tracking, but someone else might be adventuresome enough one day. I think prefix ha[s|d] a wxMac port going.
Comment 15 Pacho Ramos gentoo-dev 2012-04-11 07:49:18 UTC
OK, as I pointed in ML I was clearly wrong with my interpretation of wxwidgets USE flag meaning, sorry to Samuli and Alexis for his time :-(.
Comment 16 Pacho Ramos gentoo-dev 2012-04-17 08:35:14 UTC
This was fixed as the change was committed to desktop profiles yesterday