Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 409705 - media-sound/qjackctl-0.3.8: migrate to qt4-r2.eclass
Summary: media-sound/qjackctl-0.3.8: migrate to qt4-r2.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: qt4eclass
  Show dependency tree
 
Reported: 2012-03-25 22:20 UTC by Davide Pesavento
Modified: 2012-03-28 09:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qjackctl-0.3.8.ebuild.patch (qjackctl-0.3.8.ebuild.patch,1.47 KB, patch)
2012-03-25 22:20 UTC, Davide Pesavento
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Pesavento gentoo-dev 2012-03-25 22:20:57 UTC
Created attachment 306659 [details, diff]
qjackctl-0.3.8.ebuild.patch

qt4.eclass is deprecated; attached patch implements the (easy) migration to qt4-r2 and EAPI=4. Please apply or give an ACK and we'll apply it.

Thanks!
Comment 1 Alexis Ballier gentoo-dev 2012-03-26 12:03:40 UTC
shouldnt DOCS be a bash array?
Comment 2 Davide Pesavento gentoo-dev 2012-03-26 13:04:59 UTC
(In reply to comment #1)
> shouldnt DOCS be a bash array?

Nope, qt4-r2.eclass doesn't support arrays (yet) for the DOCS variable.
Comment 3 Alexis Ballier gentoo-dev 2012-03-26 13:08:00 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > shouldnt DOCS be a bash array?
> 
> Nope, qt4-r2.eclass doesn't support arrays (yet) for the DOCS variable.

a pitty :(

but otherwise, patch is good, so please feel free to commit
Comment 4 Davide Pesavento gentoo-dev 2012-03-27 12:14:05 UTC
Patch committed. Thanks Alexis!

Can we proceed to stabilize 0.3.8?
Comment 5 Alexis Ballier gentoo-dev 2012-03-27 14:06:22 UTC
(In reply to comment #4)
> Can we proceed to stabilize 0.3.8?

if you want yes
Comment 6 Davide Pesavento gentoo-dev 2012-03-27 16:10:21 UTC
@amd64, please stabilize =media-sound/qjackctl-0.3.8, so we can prune older versions which inherit the deprecated eclass. Thanks!
Comment 7 Agostino Sarubbo gentoo-dev 2012-03-28 09:59:09 UTC
amd64 stable, closing