Bug 407401 – www-client/chromium-9999 build failure: ‘kNumberStyle’ is not a member of ‘icu_48::NumberFormat’

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Julien Sanchez 2012-03-08 10:18:17 UTC]

Created attachment 304615 [details]
gzipped build log

As of upstream webkit changeset 109876 (http://trac.webkit.org/changeset/109876), chromium-9999 fails to build with:

...
third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.cpp: In member function ‘void WebCore::ICULocale::initializeDecimalFormat()’:
third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.cpp:72:67: error: ‘kNumberStyle’ is not a member of ‘icu_48::NumberFormat’
...
make: *** [out/Release/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.o] Error 1

[Comment 1 Julien Sanchez 2012-03-08 10:20:50 UTC]

Created attachment 304617 [details]
emerge --info chromium icu

[Comment 2 megabaks 2012-03-08 18:31:30 UTC]

....
		\! -path 'third_party/icu/*' \
....
		-Duse_system_icu=0
...

[Comment 3 Paweł Hajdan, Jr. (RETIRED) 2012-03-09 11:10:21 UTC]

(In reply to comment #2)
> ....
> 		\! -path 'third_party/icu/*' \
> ....
> 		-Duse_system_icu=0
> ...

That's only the last resort. We should be able to use the system ICU, and make upstream fix any incompatibilities.

Possible idea: does the build work with icu-4.6? It's only a test, *not* a fix.

[Comment 4 megabaks 2012-03-10 14:59:13 UTC]

4.6?
no way!
4.6 4.8.1-r2 (~)4.8.1-r3 4.8.1.1-r1
<1062 work fine with icu-4.8

[Comment 5 megabaks 2012-03-11 11:42:19 UTC]

(In reply to comment #3)
> (In reply to comment #2)
> > ....
> > 		\! -path 'third_party/icu/*' \
> > ....
> > 		-Duse_system_icu=0
> > ...
> 
> That's only the last resort. We should be able to use the system ICU, and
> make upstream fix any incompatibilities.
> 
> Possible idea: does the build work with icu-4.6? It's only a test, *not* a
> fix.

may be 49 it want?
http://source.icu-project.org/repos/icu/icu/tags/release-49-rc/APIChangeReport.html

[Comment 6 Paweł Hajdan, Jr. (RETIRED) 2012-03-12 09:52:58 UTC]

Fix has been committed to webkit, see https://bugs.webkit.org/show_bug.cgi?id=80815 (probably not yet rolled into chromium).

[Comment 7 megabaks 2012-03-13 11:48:20 UTC]

(In reply to comment #6)
> Fix has been committed to webkit, see
> https://bugs.webkit.org/show_bug.cgi?id=80815 (probably not yet rolled into
> chromium).

1067 + this patch = work fine with system icu